Remove unused crate proc-macro-error #992
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Rust 1.80 there is automatic compile-time checks for unexpected cfgs. Ensure that `have_basepri` cfg is known by the compiler emitting it in the build.rs.
epontan
force-pushed
the
remove-proc-macro-error
branch
from
ee73261 to
dd57311
Compare
Fix doc list indentation lint[1] and ignore `new_without_default`[2]. [1]: https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [2]: https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
The `proc-macro-error` crate is unmaintained[1] and is causing `cargo audit` failures[1]. Since the create is not even used by `rtic`, just remove it as a dependency. [1]: https://rustsec.org/advisories/RUSTSEC-2024-0370.html
epontan
force-pushed
the
remove-proc-macro-error
branch
from
dd57311 to
e24b219
Compare
|
I realize that there is still a bunch of compilation issues left for this release branch. Is this change something that you are willing to take in and release for the v1 track? I just want to get confirmation of that before I spend too much time trying to fix things. |
|
I think it's a good thing, and as there should be no functional change I don't see why not. The work you're doing is appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
proc-macro-errorcrate is unmaintained1 and is causingcargo auditfailures1. Since the create is not even used byrtic, just remove it as a dependency.