actor API #537
actor API #537
Conversation
|
@rtic-rs/devs this PR has been rebased onto rtic 1.0 and the deps of the firmware have also been bumped 🚀 |
|
ping @korken89 this and the rtic-syntax PRs have been rebased |
|
Now with |
|
Looking at the |
|
indeed, having the temp sensor as an actor instance makes more sense. updated the example. |
see rtic-rs/rfcs#52 for details includes: core proposal and `#[init]` and `memory-watermark` extensions Co-authored-by: Jonas Schievink <[email protected]>
this way it won't be compiled by `cargo b --examples` it'll be compiled by 'cargo b --examples --features actor-watermark`
|
@korken89 review ping. (someone else also asked about when this would be merged in the matrix chat room) |
| { | ||
| fn receive(&mut self, temperature: TemperatureReadingCelsius) { | ||
| if temperature.0 >= self.threshold { | ||
| self.outbox.post(TemperatureAlert).ok().expect("OOM"); |
There was a problem hiding this comment.
Why is ok() called here when you could call expect directly on the return from post() i.e.
self.outbox.post(TemperatureAlert).expect("OOM");
There was a problem hiding this comment.
doing expect on the Result<T, E> value requires that E implements the fmt::Debug trait. doing ok().expect() places no trait requirements on the type E. TemperatureAlert does not implement the fmt::Debug trait so post(TemperatureAlert).expect() would not compile.
deriving Debug on the type and leaving out the ok() is also an option (no pun intended). I tend to write ok().expect() mostly out of bad habit. (less Result::unwrap calls produces smaller (code size) binaries but that's micro-optimizing and this is an example so that hardly matters; as I said: bad habit)
There was a problem hiding this comment.
Ahh, ok makes sense. Thanks for the reply, I was mainly just curious more than critiquing
|
What's the status of this, now that v2.0 is stable? |
The proposed path forward is to create a separate branch for actor, just like other older releases. |
this PR contains a proof-of-concept implementation of the actor API proposed in rtic-rs/rfcs#52
the files added to the
examplesdirectory are tests of the feature semanticsa full example, with multiple crates (firmware + testable
no_stdlibrary), has been included in theactor-exampledirectorydepends on rtic-rs/rtic-syntax#75