Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON parsing extension (DOC for rsyslog PR/#2773) #691

Closed
wants to merge 1 commit into from

Conversation

nhosoi
Copy link

@nhosoi nhosoi commented Jun 13, 2018

This is an update for rsyslog/rsyslog#2773 containing the following changes:

  • Adding parameters variable, alt_variable and compact to mmjsonparse.
  • Adding parse_json extension "json_parse_ex" which supports compact.

@nhosoi
Copy link
Author

nhosoi commented Jun 13, 2018

The build failed with this error... Could you please enlighten me what was wrong in this PR? Thanks!!
fatal: Couldn't find remote ref refs/pull/691/merge

@@ -87,7 +87,7 @@ Note: parameter names are case-insensitive.

*(Available since: 8.5.1)*

Specifies if a variable insteed of property 'msg' should be used for
Specifies if a variable insted of property 'msg' should be used for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead

@richm
Copy link
Contributor

richm commented Jun 13, 2018

@nhosoi try rebasing on top of the latest master

Adding parse_json extension "json_parse_ex" which supports compact.
@nhosoi nhosoi force-pushed the parse_json_extension4 branch from 03fb4fa to b7e64c2 Compare June 13, 2018 19:36
@nhosoi
Copy link
Author

nhosoi commented Jun 13, 2018

Thank you, @richm. I thought I fixed it when I copied the section from mmnormalize, but I added another typo. :p Fixed both.

mmjsonparse.rst:   Specifies if a variable insted of property 'msg' should be used for
mmnormalize.rst:   Specifies if a variable insted of property 'msg' should be used for
==>
mmjsonparse.rst:   Specifies if a variable instead of property 'msg' should be used for
mmnormalize.rst:   Specifies if a variable instead of property 'msg' should be used for

Regarding "rebasing on top of the latest master", I've done that just before creating this pr. So, it's up to date...

@nhosoi
Copy link
Author

nhosoi commented Jun 13, 2018

/retest

@rgerhards
Copy link
Member

The build failed with this error... Could you please enlighten me what was wrong in this PR? Thanks!!
fatal: Couldn't find remote ref refs/pull/691/merge

That's apparently a race in the github notification API. We see this occasionally. It looks like the commit is not actually available on all github front-end servers at the time the notification is sent out. If buildbot then starts up very quickly, we can hit that problem.

We are investigating how to work-around it. Most probably, we will just add an initial "sleep step" to the buildbot configs.

@nhosoi
Copy link
Author

nhosoi commented Jul 27, 2018

Closing this Doc PR along with the primary PR.
rsyslog/rsyslog#2773

Thank you for the discussions, @davidelang, @rgerhards, and @richm.
I've submitted a pr for skipempty to liblognorm. I'd greatly appreciate it if you could take a look at it.
rsyslog/liblognorm#305

Since some of the necessary features are already in mmnormalize and the rest could be added by the liblognorm pr305, let me close this pr as well as the doc pr (DOC for rsyslog PR/#2773) #691.

@nhosoi nhosoi closed this Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants