Bootstrap 5 testing #159
Draft
Bootstrap 5 testing #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies all relevant testing apps to use Bootstrap 5 (i.e.,
bslib::bs_theme(version = 5)).After discussing with @shalutiwari today, we're thinking we won't expand the usual testing matrix to include Bootstrap 5. Instead, once we're close to a releasing, we'll open a PR like this one to get results for a specific version of Bootstrap that we're interested in. For this release, we need to specifically opt-in to using
version = 5(sinceversion = 4is still the default), but after this release it probably makes sense to maintain abslibbranch that addsbs_theme()instead ofbs_theme(version = 5).