Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the documentation of sendBinaryMessage function. #3744

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hq9000
Copy link

@hq9000 hq9000 commented Dec 2, 2022

previously, the documentation referred to a non-existent addBinaryMessageHandler function to be called on the frontend side. Experimentally, it was found out that the same addCustomMessageHandler just works. This is the function used to register handlers of other custom messages.

previously, the documentation referred to a non-existent `addBinaryMessageHandler` function to be called on the frontend side. Experimentally, it was found out that the same `addCustomMessageHandler` just works. This is the function used to register handlers of other custom messages.
@CLAassistant
Copy link

CLAassistant commented Dec 2, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ cpsievert
❌ hq9000
You have signed the CLA already but the status is still pending? Let us recheck it.

NEWS.md Outdated Show resolved Hide resolved
@cpsievert
Copy link
Collaborator

Thanks @hq9000! It'd be helpful if you could run devtools::document() and push up the changes.

@hq9000
Copy link
Author

hq9000 commented Jan 21, 2023

Thanks @hq9000! It'd be helpful if you could run devtools::document() and push up the changes.

hi @cpsievert! It's done. Thanks for pointing out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants