handle empty description in articles json when creating the XML feed #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderv
force-pushed
the
listing/no-description
branch
from
cf80092 to
4c5d4d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NULL in R gives empty list in JSON (when read back). Testing for NULL was not correct to default for
titlewhen nodescriptionis provided.This is now handled correctly and should avoid cryptic error from XML writing. Fix #490 and fix #448
The code base is from several years ago, so it is surprising that this was never reported before. Probably a non empty
descriptionhas always been provided. 🤷