Merge rspec repos #48

Defaulted most new things to off, though tried to keep performance and linters.

* r61510, ruby/ruby@e7c1cbe * https://bugs.ruby-lang.org/issues/14250

$SAFE became a global variable in Ruby 2.6

@Private

* Added @Private tag for nested class (no longer inherits). * Included full method definition in generated should/should_not docs. * Used const_set for constant redefinition, since using = confuses YARD. * Added short descriptions to methods that are @api private. Could probably just @Private the lot but didn't want to make that decision here.

Update yard to 0.9.12, motivated by CVE.

Upgrade rubocop, motivated by CVE.

* If it quacks like a Hash, treat it like a Hash * DRY * Not loaded by default in old Rubies * Trying to get the build passing... * No need to put this on Relish * Not much value to pseudo-hashes allowed as expecteds

[ci skip]

Upgrade rubocop, motivated by CVE.

We did not offer it when the BisectFormatter was written but it nicely simplifies it now. Also, get the expected failures in `initialize` instead of `start`.

Simplify BisectFormatter using `example_finished` notification.

It is not going to be needed for the ForkRunner, but it will have its own lifecycle to manage, so `start { }` makes a convenient interface for both.

Also, rename the bisect formatter to indicate it communicates over DRb.

Also, move it to `utilities` as the server will not always be loaded.

This is useful for when you want to initialize your formatter with extra state. The simplest approach is for you to instantiate the formatter yourself instead of depending on RSpec to do it and trying to update the formatter with your desired state later.

…n_configuration [#2494] Add yard return values to Rspec::Core::Configuration

Nicely handle errors encountered from processing `--require`.

…ings Bisect forker prep refactorings

Use a simple `Notifier` instead of the full-fledged `Reporter` (which required the use of config). Avoiding config is necessary for us to be able to use the new forking runner for bisect.

Avoid using `RSpec.configuration` from the bisect coordinator.

[ci skip]

Fix typo

Improve performance of bisect using new forking bisect runner

See rspec/rspec-core#2327. git:// URLs are insecure and cause recent versions of Bundler to emit a warning.

Use https:// instead of git:// for README URLs

I missed this in cf84052.

Use https:// instead of git:// for DEV-README

See rspec/rspec-core#2518.

This commit fixes the following build error of ruby-head (Ruby 2.6) . ```console Failures: 1) RSpec::Core::Formatters::ProgressFormatter produces the expected full output Failure/Error: @example_group_instance.instance_exec(*args, &block) RuntimeError: Warnings were generated: /home/travis/build/rspec/rspec-core/lib/rspec/core/configuration_options.rb:171: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments. /home/travis/build/rspec/rspec-core/lib/rspec/core/configuration_options.rb:171: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead. # /home/travis/build/rspec/rspec-support/lib/rspec/support/spec/stderr_splitter.rb:54:in `verify_no_warnings!' # /home/travis/build/rspec/rspec-support/lib/rspec/support/spec.rb:25:in `block (2 levels) in <top (required)>' # ./lib/rspec/core/example.rb:447:in `instance_exec' # ./lib/rspec/core/example.rb:447:in `instance_exec' # ./lib/rspec/core/hooks.rb:355:in `run' # ./lib/rspec/core/hooks.rb:507:in `block in run_owned_hooks_for' # ./lib/rspec/core/hooks.rb:506:in `each' # ./lib/rspec/core/hooks.rb:506:in `run_owned_hooks_for' # ./lib/rspec/core/hooks.rb:593:in `block in run_example_hooks_for' # ./lib/rspec/core/hooks.rb:592:in `each' # ./lib/rspec/core/hooks.rb:592:in `run_example_hooks_for' # ./lib/rspec/core/hooks.rb:463:in `run' # ./lib/rspec/core/example.rb:507:in `run_after_example' # ./lib/rspec/core/example.rb:273:in `block in run' # ./lib/rspec/core/example.rb:500:in `block in with_around_and_singleton_context_hooks' # ./lib/rspec/core/example.rb:457:in `block in with_around_example_hooks' # ./lib/rspec/core/hooks.rb:464:in `block in run' # ./lib/rspec/core/hooks.rb:604:in `block in run_around_example_hooks_for' # ./lib/rspec/core/example.rb:342:in `call' # ./spec/support/sandboxing.rb:16:in `block (3 levels) in <top (required)>' # ./lib/rspec/core/sandbox.rb:29:in `sandboxed' # ./spec/support/sandboxing.rb:7:in `block (2 levels) in <top (required)>' # ./lib/rspec/core/example.rb:447:in `instance_exec' # ./lib/rspec/core/example.rb:447:in `instance_exec' # ./lib/rspec/core/hooks.rb:373:in `execute_with' # ./lib/rspec/core/hooks.rb:606:in `block (2 levels) in run_around_example_hooks_for' # ./lib/rspec/core/example.rb:342:in `call' # ./lib/rspec/core/hooks.rb:607:in `run_around_example_hooks_for' # ./lib/rspec/core/hooks.rb:464:in `run' # ./lib/rspec/core/example.rb:457:in `with_around_example_hooks' # ./lib/rspec/core/example.rb:500:in `with_around_and_singleton_context_hooks' # ./lib/rspec/core/example.rb:251:in `run' # ./lib/rspec/core/example_group.rb:629:in `block in run_examples' # ./lib/rspec/core/example_group.rb:625:in `map' # ./lib/rspec/core/example_group.rb:625:in `run_examples' # ./lib/rspec/core/example_group.rb:591:in `run' # ./lib/rspec/core/runner.rb:116:in `block (3 levels) in run_specs' # ./lib/rspec/core/runner.rb:116:in `map' # ./lib/rspec/core/runner.rb:116:in `block (2 levels) in run_specs' # ./lib/rspec/core/configuration.rb:1975:in `with_suite_hooks' # ./lib/rspec/core/runner.rb:111:in `block in run_specs' # ./lib/rspec/core/reporter.rb:74:in `report' # ./lib/rspec/core/runner.rb:110:in `run_specs' # ./lib/rspec/core/runner.rb:87:in `run' # ./lib/rspec/core/runner.rb:71:in `run' # ./lib/rspec/core/runner.rb:45:in `invoke' # ./exe/rspec:4:in `<top (required)>' # script/rspec_with_simplecov:42:in `load' # script/rspec_with_simplecov:42:in `<main>' ``` https://travis-ci.org/rspec/rspec-core/jobs/346647744#L1004-L1060 The following addresses are related commits. - ruby/ruby@cc777d0 - ruby/ruby@8b9a3ea

See: rspec/rspec-dev@3f380ca

…018-02-27-for-master Updated travis build scripts (from rspec-dev)

…_ruby_2_6 Deprecate safe_level of `ERB.new` in Ruby 2.6

- After 2.6 is released we still have to support older ruby versions so we cannot remove this. - We can only remove it once we stop supporting RUBY_VERSION < 2.6. - We search for RUBY_VERSION uses when dropping old versions and do not need a FIXME. [ci skip]

…018-03-04-for-master Updated travis build scripts (from rspec-dev)

Pin ffi on RBX / 1.8

…ismatch Fix spec name/assertion mismatch.

…ring_dry_runs Don't write status file during dry runs.

…04-03-for-master Updated travis build scripts (from rspec-dev)

…04-03-for-master Updates from rspec-dev (2018-04-03)

…2018-04-17-for-master Updated common markdown files (from rspec-dev) [ci skip]

This is a XDG Base Directory Specification compatible alternative to ~/.rspec. ~/.rspec has higher precedence in order to reduce risk in cases where users have a file like this dormant. It is unlikely, but this way the risk is lower. If $XDG_CONFIG_HOME is not set, it will fall back to ~/.config, per the specification. Other changes: The "isolated home" example tag has been extended with a `create_fixture_file` helper that also takes care to create the directory where the file resides in, if it does not already exist. Other file creations have been migrated to this method for consistency. The method is only available when an example is tagged with `:isolated_home => true`, for safety. In case the developer running these tests have a custom $XDG_CONFIG_HOME set, it is cleared out when using an isolated home so their real files are not touched.

If the two arrays are the same, `find()` returns `nil`. This case must be accounted for

Add test for #2515

…ter-length-configurable Fix tests for 951 + rdoc first word needs to match the variable

…(#1057) See : rspec/rspec-expectations#1056 (comment)

XDG config file completely overrides HOME file.

Add support for XDG base directory support for configuration file

…message Refine ExpectationNotMetError message

Add filter_examples method

[ci skip]

…n::Include (#1069)

Remove duplicate word

typo

Support checking `initialize` when checking `respond_to(:new)`

Only call to_hash when actual object does not respond to include?

Prevent Github vulnerability warning

If when looking up match results, a match result for a matcher is empty, we will get a KeyError, this is now converted into an ArgumentError with explanation.

Handle unexpected Index / KeyError when looking up match results

…09-19-for-master Updates from rspec-dev (2018-09-19)

* Single error when `--require`'d files fail to load When there's an error loading files specified via the `--require` flag, typically `rails_helper.rb` or `spec_helper.rb`, it's very common that most of the spec files won't load either since they depend on the helper file being loaded. In these situations, one gets hundreds of errors printed to the screen. That can be quite intimidating and contributes to hide the real culprit, which is the load error in the helper.

With the previous documentation, it was unclear if the passed in tag using the `@` (cucumber style tagging) would be ignored similar to doing `~tag` (for `--tag @tag`), or if it would "ignore" the `@` when building the configuration option (`@tag` changes to `:tag`). Looking at the implementation in `lib/rspec/core/option_parser.rb` confirms that it is the latter, so the wording has been updated to make that more clear.

* Add project metadata to the gemspec * Use the official rspec.info documentation page * Use tagged changelog

Add project metadata to the gemspec

When the user create a test with CP932 encoding and japanese chars RSpec fail to properly display characters or crash with the error: > Encoding::CompatibilityError: incompatible character encodings: Windows-31J and UTF-8 Fix: - rspec/rspec-core#2570 - rspec/rspec-core#2543 For Ruby 1.8.7 We are following the same behavior as for rspec-support https://github.com/rspec/rspec-support/blob/9940a8656071655b807f772f36101b4d27f1b67d/lib/rspec/support/spec/string_matcher.rb#L8

chcp 65001 mean Code Page Number and 65001 is UTF-8. So by doing this change we modify the code page to UTF-8 for the commande that follows. See documentation: https://ss64.com/nt/chcp.html See related issue: appveyor/ci#2107

Instead of runtime see https://github.com/rspec/rspec-core/pull/2575/files#r227002134

…018-11-17-for-master Updated travis build scripts (from rspec-dev)

`RSpec::Matchers::BuiltIn::All` keeps track of which objects failed at which index of the actual value in a `@failed_objects` hash. The matcher considers a match successful if `@failed_objects` is empty. When the matcher is composed inside another matcher, the matcher gets cloned before matching against each item in the actual collection. The `@failed_objects` hash doesn't itself get cloned, resulting in each cloned matcher having a reference to the same hash. This means that once a matcher (or one of its clones) fails – populating `@failed_objects` –, each of its clones will fail matching regardless of whether it matched or not, as each clone's `@failed_objects` reference is not empty. This leads to behavior like the following, where we see the first failure (expecting `false` to be `true`) repeated twice. ``` expect([[true], [false]]).to all(all(be(false))) RSpec::Expectations::ExpectationNotMetError: expected [[true], [false]] to all all equal false object at index 0 failed to match: expected [true] to all equal false object at index 0 failed to match: expected false got true object at index 1 failed to match: expected [false] to all equal false object at index 0 failed to match: expected false got true ``` The solution here is to clone the `@failed_objects` hash when the matcher itself is cloned. So long as the matcher itself is cloned immediately after construction (while `@failed_objects` is empty) – which is what actually happens – we avoid this bug. Alternative solutions include: * calling `@failed_objects.clear` at the start of each `matches?` call * lazily defining `@failed_objects` (i.e. outside of the constructor) so that when the matcher is cloned, `@failed_objects` isn't defined yet and so cannot have shared references to it However, the pattern already exists where, when the matcher is cloned, its 'submatcher' (composed matcher) is cloned. Cloning `@failed_objects` at this time follows the same pattern.

Handle RSpec description with japanese char in CP932 encoded files

* Add chained matchers example to raise_error Being new to rspec, it wasn't clear that I could pass composed matchers to 'raise_error'. This commit adds an example of a chained matcher being passed to 'raise_error'. This is useful for testing custom attributes on an error while still satisfying the one 'expect' statement per test case enforced by rubocop-rspec. See rubocop/rubocop-rspec#379 for more details.

… deprecated; it always returns nil (#2582)

* Updated travis build scripts (from rspec-dev) * Skip broken spec on windows

#1034 introduced a hash comparison in addition to an equality check. The change compared not only the objects themselves, but also their hashes which broke for poorly behaving Ruby objects. E.g. (using `rspec-rails`): it { expect { 'noop' }.not_to change { country.reload.cities } } By caching the hash immediately after the block has run we should be able to work around such examples.

Add support for --example-matches / -E that allows matching examples with regex syntax, fixes #2584

* Add did_you_mean functionality to rspec-core. The functionality provides for suggestions when a person enters an rspec spec/some_file_path command with typographical errors. If there are errors, then the code at lib/rspec/core/configuration.rb:2037 searches for suggestions. If useful suggestions are found they are added to the reported exception at lib/rspec/core/configuration.rb:2038. The suggestions are done by the ::DidYouMean::SpellChecker API where available.

* Depend on latest Aruba release * Aruba has deprecated `in_current_directory` fix that * Remove remaining use of in_current_dir * Replace use of clean_current_dir with setup_aruba * Remove use of deprecated #dirs method * Replace #remove_file with #remove * Replace #set_env with #set_environment_variable * Replace call to #run_simple with #run_command_and_stop * Remove custom fail-with-output step * Remove custom pass-with-output step * DRY up output checks by reintroducing all_output helper

BasicObject doesn't define certain Ruby methods matchers rely on, in this case issue an ArgumentError to better explain the error. * Added kindly failure message for rspec/rspec-expectations#1105 * raise ArgumentError instead of printing special failure message * added examples for following cases - actual object does not respond to #kind_of? method - actual object does not respond to #is_a? method * removed #error_message method and give the error message inline

…eck (#1112) * "KindOf" matchers: Rescue `NoMethodError` instead of `respond_to?` check * "BeAnInstanceOf" matcher: Rescue `NoMethodError` inline * BeAKindOf matcher: improve performance & error message * BeAKindOf matcher: revert performance improvement * BeAKindOf matcher: remove #is_a? support

* Add a minimalisr formatter This formatter outputs failures in a similar fashion to the C compiler — file:line:message — allowing straightforward integration with text editors like vim and without adding extra dependencies to the project (relying on the quickfix-window from vim or similar feature for other editors). One can configure his editor with the following line (vim) and start jumping between failures using the regular editor keybindings, without having to visually parse the output from rspec to find out the file and line number he want to reach: ```vim autocmd FileType ruby set makeprg=bundle\ exec\ rspec\ --format\ m ```

Related: https://github.com/rspec/rspec-core/pull/2614/files#r284276797

The name was not matching case statement in formatters.rb and it is much simplier to have an argument with that name. Discussion: - https://github.com/rspec/rspec-core/pull/2624/files#r284776400

Rename option for FailureList formatter to "failures"

CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699

Fixes #2627 Documentation for `described_class` was out of date, a change was made in early 3.0 in #1361, but was not reflected to the docs. Also, documentation for implicit `subject` was off, even though there is a feature describing how it behaves.

…ples-doc Fix documentation for nested described_class

For example: ``` RSpec.configure do |c| c.define_derived_metadata(:elasticsearch) do |meta| meta[:vcr] = true end c.define_derived_metadata(:vcr) do |meta| meta[:retries] = 2 end end ``` With this configuration, an example or group tagged with `:elasticsearch` should get tagged with `:vcr` as well, which in turn should add `retries: 2` metadata to the example or group. Before this change, this did not work properly, because we did look to see if additional metadata blocks should apply after applying them once.

* Specify target Ruby version for RuboCop Even though the aim is to provide 1.8+ support, RuboCop of the bundled version only supports versions 2.1-2.5. This reduces the severity of the following offence: rspec-expectations.gemspec:30:29: C: Gemspec/RequiredRubyVersion: required_ruby_version (1.8, declared in rspec-expectations.gemspec) and TargetRubyVersion (2.5, declared in .rubocop.yml) should be equal. s.required_ruby_version = '>= 1.8.7' ^^^^^^^^^^ * Fix Style/Encoding offence * Set FrozenStringLiteralComment style to never `frozen_string_literal` is not used anywhere in the code, only adding the noise (~200 offenses) in the RuboCop check. * Fix Layout/EmptyLines offence * Fix Gemspec/OrderedDependencies offence * Fix percent literal related offences Specifically: - Style/PercentLiteralDelimiters - Style/UnneededPercentQ - Style/BarePercentLiterals And find common ground for the usages to minimize the change. * Disable Gemfile cops They doesn't seem to cut it in a Gemfile with conditionals * Fix Layout/SpaceAfterComma offences * Disable Lint/AmbiguousRegexpLiteral cop for step definitions * Fix Style/SpaceInsideBlockBraces offences Use default styles for Style/SpaceInsideBlockBraces * Fix Layout/TrailingBlankLines offences * Disable Style/BlockComments cop There's a really long explanation in the benchmark code. The diff size is intolerable. * Exclude Gemfile from Security/Eval check * Disable Layout/AlignParameters locally Even though this cop is coming from rspec-dev's default RuboCop settings, in this repository it's kind of cumbersome to enforce either of the styles the cop can enforce. * Fix Style/ColonMethodCall offences * Exclude specs from Metrics/ModuleLength check * Fix Layout/SpaceInsideHashLiteralBraces offences Using the default styles reduces the total change of the code required, since with defaults the number of offences is the lowest. | `space` (default) | `no_space` | `compact` ------------------- | ----------------- | ---------- | --------- `no_space` (default) | 92 | 126 | 92 `space` | 105 | 139 | 105 * Exclude specs from Metrics/BlockLength check * Disable Style/WordArray cop * Fix Layout/SpaceBeforeBlockBraces offences * Fix Style/AsciiComments offence Looks even more furious now. * Disable Lint/HandleExceptions for benchmarks * Disable Lint/HandleExceptions in the code This handling is there to avoid odd messages when this example fails * Disable Style/Semicolon Sometimes it's more indicative. It is very tempting to simplify expect { x = 0 expect { x += 1; exit }.to change { x }.and cause_call_stack_jump }.to raise_error(/no match results, [\.\w\s]+ declare `expects_call_stack_jump\?`/) down to expect { expect { exit }.to change { }.and cause_call_stack_jump }.to raise_error(/no match results, [\.\w\s]+ declare `expects_call_stack_jump\?`/) however, maybe I just don't see how `x` facilitates the understanding how a call stack jump is detected in a composable matcher. * Exclude specs and benchmarks from Style/SingleLineMethods check * Fix Style/NumericLiterals offences * Exclude specs and benchmarks from Style/RescueModifier check * Fix Performance/StringReplacement offence * Fix Style/LineEndConcatenation offences * Auto-correct Lint/UnusedBlockArgument offences I'm not particularly sure about this commit. Probably some of the examples are there specifically to indicate a bad code and how RSpec is able to handle it anyway. * Fix Style/RedundantSelf offences * Fix Style/EvenOdd offence * Exclude specs from Style/MultilineBlockChain check * Fix some Lint/IneffectiveAccessModifier offences * Fix Style/MixinGrouping offence * Exclude specs from Style/ClassAndModuleChildren check I tried fixing this across all specs, since it also triggers Metrics/ModuleLength cop, but it turns out that this style is specifically useful if a number of constants are used in the tests, e.g. it's possible to specify `RSpec::Expectations::MultipleExpectationsNotMetError` just by the class name, leaving out the namespace. * Exclude specs from Lint/AmbiguousBlockAssociation check The following notation is quite widespread expect { string << "c" }.to change { string } and it would look extremely odd being "fixed": expect { string << "c" }.to(change { string }) Even though sometimes it's hard to figure out what is the receiver of the message with composable matchers, the matchers are built the way it doesn't really matter. * Exclude specs from Style/BracesAroundHashParameters check This style makes total sense in specs, e.g.: expect({:a => 1, :b => 2}).to include(:a => 1, :b => 2) indicates that `actual` is a hash. * Exclude specs from Layout/SpaceInsideParens check This style looks quite nicely: by( a_value_within(0.1).of(0.5) ) especially when chained with another matcher down the lines. An example with `compose` in spec/rspec/matchers/built_in/compound_spec.rb:56:16 expect { w += 1; x += 2; y += 3; z += 4 }.to( combine( change { w }.to(1), combine( change { x }.to(2), combine( change { y }.to(3), change { z }.to(4) ) ) ) ) is there for a single reason - lack of varargs in earlier, but still supported Ruby versions. * Exclude specific file from Style/EvalWithLocation check The `__LINE__` would be completely useless for evals in this spec. * Fix Layout/SpaceInsideArrayLiteralBrackets offences One of the "offences" that went into the exclude file is there to visually demonstrate what is in the `actual`. * Disable Style/GlobalVars inline I tried to keep off of in-code disabling of the cops, but since this specific line is a hack, probably it makes sense to highlight it as such. * Disable Gemspec/RequiredRubyVersion Minimum Targeted Ruby version of used RuboCop is 2.1, while even it was dropped in rubocop/rubocop@a707c23 2.2 is past the support phase, and so will be 2.3 by the end of March 2019. * Fix Layout/SpaceInsideReferenceBrackets offence * Fix Style/Attr offence * Locally disable Style/RedundantException offences As per https://github.com/rspec/rspec-expectations/pull/1104/files#r263923497 discussion it's better to be explicit, and to suppress the cop * Fix Layout/EmptyLinesAroundModuleBody offences * Fix Style/NumericLiteralPrefix offences * Fix Layout/SpaceAroundEqualsInParameterDefault offences * Fix Layout/EmptyLinesAroundClassBody offence * Fix Style/EmptyLiteral offences * Fix Lint/UnusedMethodArgument offences * Fix Performance/RedundantBlockCall offence * Explicitly denote that the code is unreachable It's quite obvious anyway from looking at the code, though it is a balancing example and deserves to remain as is. However, instead of excluding this file in .rubocop.yml, it makes sense to additionally denote that the code is unreachable in the code itself. * Locally disable Lint/RescueException offence Discussion: https://github.com/rspec/rspec-expectations/pull/1104/files#r263990646 * Fix Style/MethodCallWithoutArgsParentheses offences Also, this changes reverts fdd9ef3, for which the warnings should not appear anymore (see https://bugs.ruby-lang.org/issues/10661). * Fix Layout/IndentationConsistency offence * Exclude ignored paths from RuboCop checks Aruba creates some tmp files that don't pass the checks. Also, git ignored bin folder (of an unknown origin, probably part of how rspec-dev checks out and initializes repositories) contains a number of offences. bin/bundle:34:25: C: Style/PerlBackrefs: Avoid the use of Perl-style backrefs. ^^ bin/bundle:89:187: C: Metrics/LineLength: Line is too long. [190/186] tmp/aruba/rspec_expectations_spec.rb:48:4: C: Layout/TrailingBlankLines: Final newline missing. It doesn't make sense to fix them, since those files are not meant to be committable. * Add RuboCop check to default rake task * Fix typos and RuboCop reference in docs * Add a check for RuboCop binstub * Tell RuboCop to check all files Previously CI check was only checking `lib` directory * Locally disable Layout/EmptyLinesAroundArguments It is a bug in RuboCop 0.52.1, fixed in 0.65.0 Adding a local disabling, since newer RuboCop will report an unnecessary disabling, and it could be spotted and removed. * Simplify regression test The test was a bit confusing. The point of it is that if a `matches?` is defined, and `===` is not defined, it should not be used as an argument matcher. rspec/rspec-expectations#1104 (comment)

Add support for running Rake task in a clean environment

Since derived metadata hooks can contain arbitrary user code, the logic in them can trigger something that tries to access and use `Example#metadata` or `ExampleGroup#metadata` before initialization is done. It avoids problems if we allow `@metadata` to be assigned before we run the hooks.

…-bug Assign `@metadata` before we apply derived metadata hooks.

- Bump dependency version - Fix deprecations - Limit version of transitive dependency on contracts gem on old Rubies

…07-08-for-master Updates from rspec-dev (2019-07-08)

See: rspec/rspec-core#2651

…07-24-for-master Updates from rspec-dev (2019-07-24)

When using `example.reporter.message`, it would be nice if the messages were indented correctly, so that it's clear it relates to the current spec being executed.

Force --no-profile for output dependant specs

…ed blocks (#1130) * Add support for not swallowing expectation errors * Add changelog for #1130

Indent messages correctly in DocumentationFormatter.

* Add instance variables to changes detected * Add benchmark for large objects

Update docs for hooks specifying order of before/around/after

…rget https://blog.rubystyle.guide/rspec/2019/07/17/rspec-implicit-block-syntax.html https://rspec.rubystyle.guide/#implicit-block-expectations Spec changes are due to: matcher.matches?(invalid_value) doesn't work with block-only matchers, as no block is passed in, and it fails with a message: 1) RSpec::Matchers::BuiltIn::Change behaves like an RSpec block-only matcher uses the `ObjectFormatter` for `failure_message` Failure/Error: expect(message).to include("detailed inspect") expected "expected `@k` to have changed, but was not given a block" to include "detailed inspect" The redundant (due to existing check in ExpectationTarget) `Proc === @event_proc` checks could not be removed safely as well, since @actual_after is not initialized yet when we haven't executed the block: RuntimeError: Warnings were generated: rspec-dev/repos/rspec-expectations/lib/rspec/matchers/built_in/change.rb:407: warning: instance variable @actual_after not initialized Ruby 1.8-specific workarounds: multiple values for a block parameter (0 for 1) If a block expects an argument, it ought to be provided an argument in 1.8

…used-with-value-expectation-target Prevent block-only matchers from being used with value expectation target

* Notice when object implements identical `#inspect` but == returns false In a few cases the objects under test implement identical `inspect` output but the `eq` matcher will see a difference when doing `==`. This can lead to misleading output like this: ``` Failures: 1) Foo confuses users with an empty diff Failure/Error: Foo.something(Foo.new) #<Foo (class)> received :something with unexpected arguments expected: ("foobar") got: ("foobar") Diff: # ./spec/foo_spec.rb:13:in `block (2 levels) in <top (required)>' ``` This change adds a notice to help to understand this failed expectation. Fix: rspec/rspec-support#274

Pin minitest on older Rubies

…spec-repos

Commits on Mar 18, 2018

Pin ffi on RBX

JonRowe committed Mar 18, 2018

Configuration menu

View commit details

Copy full SHA for a876039

Browse repository at this point

Copy the full SHA

a876039 View commit details

Browse the repository at this point in the history

Commits on Apr 3, 2018

Pin ffi on 1.8.7

JonRowe committed Apr 3, 2018

Configuration menu

View commit details

Copy full SHA for fe11ce3

Browse repository at this point

Copy the full SHA

fe11ce3 View commit details

Browse the repository at this point in the history

Commits on Aug 7, 2018

Forwardport 3.8.1 release notes.

myronmarston committed Aug 7, 2018

Configuration menu

View commit details

Copy full SHA for 31f108e

Browse repository at this point

Copy the full SHA

31f108e View commit details

Browse the repository at this point in the history

Commits on Oct 9, 2018

Merge 3-8-maintenance

JonRowe committed Oct 9, 2018

Configuration menu

View commit details

Copy full SHA for 0025231

Browse repository at this point

Copy the full SHA

0025231 View commit details

Browse the repository at this point in the history

Commits on Mar 4, 2019

Fix classification in changelog

JonRowe committed Mar 4, 2019

Configuration menu

View commit details

Copy full SHA for 74ad029

Browse repository at this point

Copy the full SHA

74ad029 View commit details

Browse the repository at this point in the history

Commits on Apr 21, 2019

Bump to 3.8.3

JonRowe committed Apr 21, 2019

Configuration menu

View commit details

Copy full SHA for 7a5c9f7

Browse repository at this point

Copy the full SHA

7a5c9f7 View commit details

Browse the repository at this point in the history

Commits on May 15, 2019

Typo: Changelog for #2614

benoittgt committed May 15, 2019

Configuration menu

View commit details

Copy full SHA for b5b0967

Browse repository at this point

Copy the full SHA

b5b0967 View commit details

Browse the repository at this point in the history

Commits on Jun 10, 2019

Changelog for 3.8.4

JonRowe committed Jun 10, 2019

Configuration menu

View commit details

Copy full SHA for 721be32

Browse repository at this point

Copy the full SHA

721be32 View commit details

Browse the repository at this point in the history

Commits on Jun 29, 2019

Changelog for 3.8.2

JonRowe committed Jun 29, 2019

Configuration menu

View commit details

Copy full SHA for e1c0fb5

Browse repository at this point

Copy the full SHA

e1c0fb5 View commit details

Browse the repository at this point in the history

Commits on Sep 17, 2019

Wrap up bug fixes

JonRowe authored Sep 17, 2019

Configuration menu

View commit details

Copy full SHA for 4310cb9

Browse repository at this point

Copy the full SHA

4310cb9 View commit details

Browse the repository at this point in the history

Merge rspec repos #48

Are you sure you want to change the base?

Merge rspec repos #48

Commits on Jan 3, 2018

Commits on Jan 5, 2018

Commits on Jan 9, 2018

Commits on Jan 10, 2018

Commits on Jan 13, 2018

Commits on Jan 16, 2018

Commits on Jan 18, 2018

Commits on Jan 20, 2018

Commits on Jan 21, 2018

Commits on Jan 23, 2018

Commits on Jan 27, 2018

Commits on Jan 30, 2018

Commits on Feb 9, 2018

Commits on Feb 13, 2018

Commits on Feb 15, 2018

Commits on Feb 27, 2018

Commits on Feb 28, 2018

Commits on Mar 1, 2018

Commits on Mar 4, 2018

Commits on Mar 18, 2018

Commits on Mar 19, 2018

Commits on Mar 27, 2018

Commits on Apr 3, 2018

Commits on Apr 5, 2018

Commits on Apr 17, 2018

Commits on Apr 18, 2018

Commits on Apr 22, 2018

Commits on Apr 24, 2018

Commits on Apr 25, 2018

Commits on May 2, 2018

Commits on May 9, 2018

Commits on Jun 6, 2018

Commits on Jul 6, 2018

Commits on Jul 22, 2018

Commits on Aug 4, 2018

Commits on Aug 6, 2018

Commits on Aug 7, 2018

Commits on Sep 12, 2018

Commits on Sep 18, 2018

Commits on Sep 19, 2018

Commits on Sep 20, 2018

Commits on Sep 21, 2018

Commits on Oct 3, 2018

Commits on Oct 9, 2018

Commits on Oct 13, 2018

Commits on Oct 18, 2018

Commits on Oct 19, 2018

Commits on Oct 31, 2018

Commits on Nov 13, 2018

Commits on Nov 14, 2018

Commits on Nov 15, 2018

Commits on Nov 16, 2018

Commits on Nov 17, 2018

Commits on Nov 23, 2018

Commits on Nov 27, 2018

Commits on Nov 28, 2018

Commits on Dec 10, 2018

Commits on Dec 21, 2018

Commits on Dec 30, 2018

Commits on Dec 31, 2018

Commits on Jan 1, 2019

Commits on Jan 4, 2019

Commits on Jan 8, 2019

Commits on Feb 1, 2019

Commits on Feb 2, 2019

Commits on Feb 4, 2019

Commits on Feb 8, 2019

Commits on Mar 1, 2019

Commits on Mar 3, 2019

Commits on Mar 4, 2019

Commits on Mar 7, 2019

Commits on Mar 24, 2019

Commits on Apr 1, 2019

Commits on Apr 3, 2019

Commits on Apr 18, 2019

Commits on Apr 21, 2019

Commits on May 3, 2019