Present the actual error message from raise_error #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
reviewed
Nov 3, 2021
JonRowe
requested changes
Nov 3, 2021
Display the actual error message of the raised error when a raise_error asserton fails. The failure message will now include the error message on a separate line followed by the backtrace. If there is no error message, only the backtrace will be shown.
genehsu
force-pushed
the
genehsu/add-message-to-raise_error-failure-output
branch
from
c3d0c74
to
c1ddbf5
Compare
Thanks for the review. I believe I've addressed your suggestions with clearer code. Let me know if you have any other suggestions to the code or output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1190
Display the actual error message of the raised error when a raise_error
assertion fails. The failure message will now include the error message
on a separate line followed by the backtrace. If there is no error
message, only the backtrace will be shown.
If this approach is not correct, then please close this PR without prejudice 😃