Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Aliased Matchers from Overriding Expected Data #1116

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on May 24, 2019

  1. Prevent aliased matchers from overriding data

    The aliased matcher implementation of a description currently
    replaces all instance of the old matcher's name with the new
    matcher's name. However, in cases where the expected value
    has the same string as the old matcher's name, it would also
    get replaced. This change makes it so only the first instance
    of the old matcher's name is replaced in the description.
    Lucas Nestor committed May 24, 2019
    Configuration menu
    Copy the full SHA
    4bc09e8 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2019

  1. Configuration menu
    Copy the full SHA
    bee5647 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7e54f1f View commit details
    Browse the repository at this point in the history
  3. Split aliased matcher description into new class

    A flag was added when generating an aliased matcher's
    description to better control how the old matcher's name
    is replaced. However, this broke the existing API for
    overriding a matcher's new description. This class allows
    to maintain backwards compatability gracefully.
    Lucas Nestor committed May 31, 2019
    Configuration menu
    Copy the full SHA
    16b836b View commit details
    Browse the repository at this point in the history
  4. Remove keyword arguments for backwards compatibility

    Lucas Nestor committed May 31, 2019
    Configuration menu
    Copy the full SHA
    514ba9e View commit details
    Browse the repository at this point in the history