Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pacman style progressbar #37

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

FredBrockstedt
Copy link

if you like, adds a pacman style progressbar. Fixes some rounding issues and adds a demo file.

@rsalmei
Copy link
Owner

rsalmei commented May 3, 2020

Hey @FredBrockstedt,

Thanks for the PR!
But please, could you send only the bug fix? I do not want a demo.py in the root project, nor the pacman bar, which I think do not fit with the concept. It could be a cool Customization tutorial in the readme for example, but not actually builtin I think.

I will think about a contrib package or something like it, to enable user contributed content, in which case I would like very much to have your pacman bar...

@FredBrockstedt
Copy link
Author

FredBrockstedt commented May 4, 2020 via email

@rsalmei
Copy link
Owner

rsalmei commented May 7, 2020

Hey @FredBrockstedt,

Thank you for your words, I've fixed that bug myself, and released 1.5.1 yesterday. Also I understand your point about a demo, but still prefer a clean library with a good readme, so people can approach it gently.

I think you titled this PR very appropriately, it is about a new progressbar style. I'm thinking very carefully about how to contribute bars, spinners and themes in a simple way, and this PR could be its test and debut.

I've thought about a cool system with separate packages, so people would be able to pip install cool-bars to get that package. alive_progress would find this package via pkg_resources, and make the bars, spinners and themes in there available in both alive_bar and showtime exhibit. It is nice, and enables split repositories, but is more complex, requiring a setup.py and actually releasing it in PyPI. Very convoluted, not good.

So I think I'll just create a contrib package and some pattern for modules inside. Then I'll dynamically find all modules in the package, and make those resources available. A module will probably work as a namespace, so I could list available namespaces, and require one to showtime it.

What do you think, ideas, concerns?

@rsalmei rsalmei mentioned this pull request May 11, 2020
@TheTechRobo
Copy link
Contributor

What do you think, ideas, concerns?

Im not OP but I like that idea, tho imo the pip packages should start with "alive-progress-" for clarity.

@rsalmei
Copy link
Owner

rsalmei commented Jan 19, 2021

Thanks @TheTechRobo.
I'm still keeping this one open for a little while. I'd like very much to enable people's contributions, but in a simple way.
After 2.0 I'll think harder about this. But please share ideas if you have any.

@rsalmei
Copy link
Owner

rsalmei commented Apr 20, 2021

Hey @FredBrockstedt, how are you?

Look at that, your pacman bar is still reserved for a user contrib package somehow, but the demo idea has made it into 2.0!
I've implemented a super cool and advanced demo, that showcases several scenarios!
And I put it in a python module, because I figured a demo.py in the root would be very hard to call... Now it will be as simple as python -m alive_progress.tools.demo 👍
Here it is:
image

regards man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants