Allow setting floating point precision in JSON #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rs
reviewed
Apr 26, 2024
encoder_json.go
Outdated
| @@ -21,6 +21,9 @@ func init() { | |||
| json.JSONMarshalFunc = func(v interface{}) ([]byte, error) { | |||
| return InterfaceMarshalFunc(v) | |||
| } | |||
| json.FloatingPointPrecisionFunc = func() int { | |||
rs
reviewed
Apr 26, 2024
internal/json/types.go
Outdated
| @@ -311,16 +311,20 @@ func appendFloat(dst []byte, val float64, bitSize int) []byte { | |||
| case math.IsInf(val, -1): | |||
| return append(dst, `"-Inf"`...) | |||
| } | |||
| precision := FloatingPointPrecisionFunc() | |||
There was a problem hiding this comment.
Would make more sense to pass the precision as an argument.
There was a problem hiding this comment.
So I was not able to set this as a global variable because that would introduce an import loop.
If you are OK with that, I can introduce a parameter to appendFloat and then pass it everywhere it is called.
mitar
force-pushed
the
float-precision
branch
3 times, most recently
from
46f6a64
to
22fc3a9
Compare
|
@rs: Pushed with the argument. |
|
Thanks. Last thing, can you please document it in the README? |
|
@rs: Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #557.