Add additional hlog logging handlers #607
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTPVersionHandler
: Similar toProtoHandler
, just withoutHTTP/
prefix. In practice, there is alwaysHTTP/
prefix, so we can drop that (if it exists, which it does) to have more compact logs.RemoteAddrHandlerWithoutPort
: Similar toRemoteAddrHandler
, but do you really care about a remote port? Remote port makes it hard to aggregate logs based on remote IP.HostHandlerWithoutPort
: Is similar, generally you do not care on which local port you run stuff.EtagHandler
: Logs response header,Etag
, can help with debugging which version of content user got.ResponseHeaderHandler
: Similar toCustomHeaderHandler
, but for response headers. If you do canonical log lines, you probably have middleware which logs it after everything is handled, so this handler should be earlier in the middleware stack.