Migrate test-suite macro configuration out of root's ~/.rpmmacros #3524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow nobody has noticed we don't create the per-host configuration directory on install, probably didn't even in autoconf days. We'll need this now in the next commits though.
pmatilai
force-pushed
the
test-usermacros-pr
branch
from
dc4a8ad to
96f41cf
Compare
|
tests 211 and 213 break for 39578b4 and a54e29f |
dmnks
requested changes
Jan 16, 2025
|
it breaks is I checkout those patches instead of the whole branch. |
We've discussed this in the past - it would be nice if we ensured that every commit passes the CI separately, but then, it would make you wait a lot longer for it to finish. So it's really a compromise. Most of the time, I think it's fine to just CI the overall patchset. When you need to bisect/backport individual patches, that's where you may get burned, of course. |
These /usr/lib/sysimage/rpm/pubkeys paths are valid for the OS rpm in the test-container, but that might not have any correlation to the *built* rpm we're supposed to be testing here. This is masked by the %_dbpath override in the Dockerfile which we'll be removing in the next step.
This override exists to make system rpmdb accessible in eg "make shell" but it causes complications wrt the prefix (see below + next commits) and also masks test bugs (see previous commit). We can resurrect this functionality later on if we find solutions that avoid the issues. This is the first step to fixing rpm-software-management#3521.
The second step to fixing rpm-software-management#3521
The third step to fixing rpm-software-management#3521
Signing key configuration is obviously something that belongs to the user's macros, but lets get on with the times and use the new XDG config directory for that. The remaining references to ~/.rpmmacros in rpmmacro.at are related to testing behavior with the old-style configuration and need to be preserved. This is the fourth and final step to rpm-software-management#3521. Fixes: rpm-software-management#3521
pmatilai
force-pushed
the
test-usermacros-pr
branch
from
96f41cf to
02490f7
Compare
|
Dropped the whole %_dbpath override thing now - as this exercise points out it can actually mask test-bugs so we'd better find some other way of achieving that before reintroducing. All individual commits should also pass now. That's a standard we should always try to adhere to, but easy to miss... |
|
Should, but apparently I only tested "make check" 🤦 (or something). Argh. |
|
Yeah, it's the prefix biting us back in return... 🤦 |
|
This turned out quite differently from what I initially planned so I'll just close this and start a new PR instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.