Fix race condition in rpmioMkpath #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnks
reviewed
Jan 9, 2025
|
Yes, this should be ENOENT. Will fix as soon as I have a clean work dir. See Line 434 in 5a53470 The But errno is only set to ENOENT by accident. The next patch changes that. This patch keeps the same behavior for callers of urlOpen. |
|
Oh, right. Re-reading the code with |
dmnks
approved these changes
Jan 9, 2025
Callers use the errno for error reporting. Currently it is set to ENOENT by accident bubbling up from rpmMkTempFile and rpmioMkpath. As we need to change rpmioMkpath set errno explicitly to keep the errno the same for the callers of urlOpen. Related: rpm-software-management#3508
The previous implementation did stat the directory and created it if not
there. This allowed for a race condition where other rpm instances could
create the directory inbetween. This was observed in the wild for
%{_tmppath}.
Do create the directory unconditionally and if that fails see if the
directory is there already.
Not adding a test case as rpmioMkpath is heavily used all over the the
code base and tests for race conditions don't really fit in the test suite.
Resolves: rpm-software-management#3508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix race condition in rpmioMkpath
The previous implementation did stat the directory and created it if not
there. This allowed for a race condition where other rpm instances could
create the directory inbetween. This was observed in the wild for
%{_tmppath}.
Do create the directory unconditionally and if that fails see if the
directory is there already.
Not adding a test case as rpmioMkpath is heavily used all over the the
code base and tests for race conditions don't really fit in the test suite.
Resolves: #3508