Adapt Dockerfile.fedora to F39 #2748
Conversation
The fedora-repos-modular package is gone from F39. This commit makes the Dockerfile work on a F39 host with the mktree.oci backend since we override the release with "podman build --from fedora:39 ..." there.
dmnks
force-pushed
the
fix-dockerfile-f39
branch
from
732d057 to
53f4c37
Compare
There was a problem hiding this comment.
If you say so, but I find the notion of the host affecting something inside the Dockerfile (or vice versa) more than just a little mind-bending 😳
On a related note, possible alternatives include just bumping the CI to F39 now that it's out, or disabling the repos with sed like we do for the h264 repo.
I do find it ugly and hacky, too, don't get me wrong. It violates the very principle of a Dockerfile being immutable. It's only done so that the image is ensured to contain the ABI compatible dependencies of RPM with those that it was built against locally. This makes me think, do we really need to test the local, native build? I've been operating with that assumption from the start but maybe it's just backwards... We might as well just always do the build in the Dockerfile and test that, like in CI. This would simplify the whole setup a bit more, too.
This would just move the "problem" to F38 hosts where we'd call
Yeah, this sounds like a cleaner way, indeed. |
|
The local build probably needs to go eventually, but lets leave this alone for now. We need to move to other challenges... |
The fedora-repos-modular package is gone from F39. This commit makes the Dockerfile work on a F39 host with the mktree.oci backend since we override the release with "podman build --from fedora:39 ..." there.