Set %_sharedstatedir to %{_var}/lib #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually the reason why it's safe in the rpm realm is that it does change the default |
Conan-Kudo
approved these changes
Nov 3, 2023
|
If it's not obvious from my previous remark: I totally agree with the change itself, but get the rationale straight in the commit message. |
Configure traditionally sets it to %{_prefix}/com which RPM has followed
so far. But this directory is not used anywhere and everybody changes
the location to /var/lib. This also changes the default for the %configure
macro. This is safe as everyone that cares about the the sharedstatedir
had to set it manually anyway.
Resolves: rpm-software-management#2092
ffesti
force-pushed
the
sharedstatedir
branch
from
0bb4927 to
ea2315c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure traditionally sets it to %{_prefix}/com which RPM has followed so far. But this directory is not used anywhere and everybody changes the location to /var/lib. As we are only changing the macro and not the configure default this should be relatively save to do.
Resolves: #2092