Exit from mktree on failure #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, if the podman image fails to build or rpm fails to
build/install, we happily continue and run the test-suite, only to
eventually fail with some cryptic error, such as:
error: cannot find rpm
Not too helpful, indeed. Instead, just fail the whole tree preparation
process if we encounter an error.
Fix the return code of unshared() so that we don't fail on that, though.
Also, when building the RPM layer, use a proper cleanup trap instead of
ignoring SIGINT since a failing make_install() can now terminate the
script.
Fixes: rpm-software-management#2667
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if the podman image fails to build or rpm fails to build/install, we happily continue and run the test-suite, only to eventually fail with some cryptic error, such as:
Not too helpful, indeed. Instead, just fail the whole tree preparation process if we encounter an error.
Fix the return code of unshared() so that we don't fail on that, though. Also, when building the RPM layer, use a proper cleanup trap instead of ignoring SIGINT since a failing make_install() can now terminate the script.
Fixes: #2667