Skip to content

Conversation

@jannic
Copy link
Member

@jannic jannic commented Nov 27, 2025

Also provide an inherent read method so the ADC can be used without e-h 0.2

Closes: #740

@jannic
Copy link
Member Author

jannic commented Nov 27, 2025

Some doc tests still need to be updated.
Done.

Copy link
Member

@9names 9names left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Might be nice for the examples to do something about errors though - the warning comments are good but maybe we should be a better example to any would-be users?
It's not a blocking concern in any case.

@jannic
Copy link
Member Author

jannic commented Jan 9, 2026

Changes look good. Might be nice for the examples to do something about errors though - the warning comments are good but maybe we should be a better example to any would-be users? It's not a blocking concern in any case.

I wanted to add error handling, but I failed to come up with a good approach for such an easy example. Correct error handling depends on the use case, and the example doesn't have one. Sure, it could log an error message, but that wouldn't be much better than the comment.

@jannic jannic merged commit af0820a into main Jan 9, 2026
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ADC should report conversion errors

3 participants