Skip to content

Conversation

@thejpster
Copy link
Member

CI currently fails because indexmap 2.12 requires 1.82 minimum

@jannic
Copy link
Member

jannic commented Oct 30, 2025

For other crates we went the opposite way and downgraded the dependency in CI: https://github.com/rp-rs/rp-hal/blob/main/.github/workflows/rp2040_hal.yml#L70

@thejpster
Copy link
Member Author

But users won't know to do that and might be confused when we don't build out of the box on the MSRV.

As long as our MSRV is covered by a Ferrocene release, I'm relatively relaxed about updating it.

@jannic
Copy link
Member

jannic commented Nov 1, 2025

But users won't know to do that and might be confused when we don't build out of the box on the MSRV.

I don't think we can guard against that issue in any meaningful way. Even if 1.82 works today, one of our dependency might bump it's MSRV tomorrow and break the build again.

But then, we already did bump the MSRV since our last release, so it doesn't matter much if we go to 1.81 or to 1.82.

As discussed on matrix it may even be better to go directly to 1.84, so we can take advantage of the new resolver.incompatible-rust-versions=fallback setting.

@thejpster thejpster merged commit 88255c4 into main Nov 2, 2025
98 checks passed
@thejpster
Copy link
Member Author

This gets it fixed for now. We can go to 1.84 next time.

@thejpster thejpster deleted the bump-msrv branch November 2, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants