Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update demo.vue #596

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update demo.vue #596

wants to merge 1 commit into from

Conversation

vitheeshc
Copy link

maxFilesize changed to 30 mb

maxFilesize changed to 30 mb
Copy link

@Chomiciak Chomiciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This very much depends.
Bare in mind, this package will be used in various scenarios, including multiple different servers, technologies and such.
For the sake of properly guiding beginners, we should keep the limit somewhere safe under their server's limit, that is, default e.g.: 2MB for apache, 1MB for nginx, etc.

Why? Because in the process of learning, limitations they overcome should be gradual.
And they will copy-paste this code to check if it works in their environment, so ideally it should work as-is to make adjustments easier.

I would suggest to change the docs first, mention the problem and possible solutions, then think about rising the limit in our code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants