Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more robust intersection checking, inc for end of segments #17

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

rowanwins
Copy link
Owner

This PR

  • Uses robust-predicates for an initial check for intersection
  • Adds a special check for intersections of end segments that don't belong to the same contour

@smallsaucepan
Copy link
Contributor

Hi @rowanwins do you think this could solve the problem we're seeing here - Turfjs/turf#2667?

@rowanwins
Copy link
Owner Author

Hi @smallsaucepan

I've just run some tests usig the turfjs issue and have made some additional modifications, TBH I'm not sure why I never thought of checking endpoints touching 😂
Anyway this should now be resolved in this branch.
I think I'll release as a new major version.

@rowanwins rowanwins merged commit c1be69d into master Nov 20, 2024
@rowanwins rowanwins deleted the better-handle-endpoint branch November 20, 2024 10:35
@smallsaucepan
Copy link
Contributor

Brilliant. Thanks @rowanwins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants