Add nt-binary hashing method in password plugin#10096
Open
gianlucagiacometti wants to merge 2 commits intoroundcube:masterfrom
Open
Add nt-binary hashing method in password plugin#10096gianlucagiacometti wants to merge 2 commits intoroundcube:masterfrom
gianlucagiacometti wants to merge 2 commits intoroundcube:masterfrom
Conversation
Add support for 'nt-binary' password hashing method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now Roundcube’s
passwordplugin has no raw 16-byte NT hash (binary), which seems to be the cleaner storage format for FreeRADIUS, Samba , sometimes LDAP and high-volume authentication systems (16 bit storage instead of 32, direct use, no formatting problems and smaller index).I also added an alternative name for samba (nt-hex) for reason of conformity, and put a note in the config for the nt-binary DB column format.