managesieve: add support for date :zone param in UI#10080
Open
johndoh wants to merge 1 commit intoroundcube:masterfrom
Open
managesieve: add support for date :zone param in UI#10080johndoh wants to merge 1 commit intoroundcube:masterfrom
johndoh wants to merge 1 commit intoroundcube:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I understand #10076 is closed but I thought I'd have a go at adding support for the
:zoneparam into the regular UI. I did this by adding it as an advanced option for date/currentdate rules.Having the param unset remains the default behaviour so no existing rules will be impacted.
With this change if a rule is created using the Vacation UI and then saved in the regular UI the result remains the same.
I added the
datezonelabel only because of the:needed at the end of the label to match the other advanced options in en-US.The select box uses the numeric representation of the time zone e.g.
+0000as that is what sieve uses and there is no way to know which of the 26 possible named zones is intended.