Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base-toot-id becomes base-item-id in mastodon.el 1.0.13 #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

csantosb
Copy link
Contributor

No description provided.

@rougier
Copy link
Owner

rougier commented Jan 9, 2024

Can you give some more details?

@SqrtMinusOne
Copy link
Contributor

SqrtMinusOne commented Jan 18, 2024

That's right, base-toot-id was renamed to base-item-id here: https://codeberg.org/martianh/mastodon.el/commit/574c17c4bdfe43a3081ddcbde4452dd477929c02

I've just found that problem because since this commit mastodon-tl--thread uses the following to get an id:

(mastodon-tl--property 'base-item-id :no-move)

See line 1783 in mastodon-tl.el in the linked diff.

The current version of mastodon-alt still uses base-toot-id:

'base-toot-id (mastodon-tl--item-id (or parent-toot toot))

So at least mastodon-tl--thread doesn't work with mastodon-alt. This PR fixes that.

@SqrtMinusOne
Copy link
Contributor

I'd propose merging #22 because it supersedes this PR.

#22 also fixes mastodon--toot-reply in thread view.

@rougier
Copy link
Owner

rougier commented Jan 22, 2024

Thanks. I think I already merged a PR for that. Can you compare your PR with the current version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants