Modernize RuboCop usage, enable performance cops, add minitest and rake cops#2205
Open
larouxn wants to merge 1 commit intorouge-ruby:masterfrom
Open
Modernize RuboCop usage, enable performance cops, add minitest and rake cops#2205larouxn wants to merge 1 commit intorouge-ruby:masterfrom
larouxn wants to merge 1 commit intorouge-ruby:masterfrom
Conversation
jneen
reviewed
Feb 4, 2026
395abc7 to
3f4534f
Compare
c06731d to
b2a2286
Compare
larouxn
commented
Feb 6, 2026
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: "4.0" | ||
| ruby-version: "3.0" |
Contributor
Author
larouxn
commented
Feb 7, 2026
3cb7fd9 to
acb0d8e
Compare
Member
Contributor
Author
|
👋 No worries! This PR and #2206 have been rebased. Just one quick note, it appears we have two |
acb0d8e to
62ee038
Compare
62ee038 to
e25aa9f
Compare
Member
|
Great catch, my bad! I'll take another look. |
Member
|
I'm getting this error running Edit: looks fixed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes our RuboCop stack to latest, adds cops for Minitest and Rake, and enables
rubocop-performance. It's been in the Gemfile but not enabled for seemingly years. Note, this is part 1, hence the large.rubocop_todo.ymladdition. Part 2 will correct much of those newly added todos via safe auto-correction..rubocop.yml#2206Note, when testing locally you'll need to update
rubocop-performanceif you have a previous installation.Requires the following (contains their commits)