Skip to content

Conversation

@Inspirateur
Copy link
Contributor

This is a copy of #1522 but for .razor files which are basically the successor of .cshtml files and use roughly the same syntax (see https://stackoverflow.com/a/56271408/8915326)

Using HTML syntax highlighting on .razor files will already be MUCH better than having no syntax highlighting at all.

I came here after reading this Gitlab issue https://gitlab.com/gitlab-org/gitlab-foss/-/issues/42855 we don't have hightlighting on .razor files on Gitlab because of this :)

added .razor files to html lexer
added razor files to html spec
@Inspirateur Inspirateur changed the title Add *.razor file glob to HTML lexer Add *.razor file glob to HTML [EASY MERGE] Mar 20, 2025
@Inspirateur
Copy link
Contributor Author

Should the maintainer role be passed on ? No interaction on such a low hanging fruit is somewhat concerning when this library is used by big projects such as GitLab :/

@tancnle
Copy link
Collaborator

tancnle commented Apr 11, 2025

@Inspirateur Thank you for your contribution. This was slipped out of my radar. LGTM 🚀

@tancnle tancnle added this pull request to the merge queue Apr 11, 2025
Merged via the queue into rouge-ruby:master with commit bdcdc59 Apr 11, 2025
8 checks passed
@Inspirateur
Copy link
Contributor Author

phew, that's reassuring :) Thank you !

@Inspirateur
Copy link
Contributor Author

When can we expect a release that includes this change ? 🥺 I think we need it for Gitlab to pick it up.

@tancnle
Copy link
Collaborator

tancnle commented Apr 22, 2025

I will cut a release sometime this week.

@Inspirateur
Copy link
Contributor Author

I will cut a release sometime this week.

Can I expect a release today then 👀 ? Thanks for your work.

xaviermignot pushed a commit to xaviermignot/rouge that referenced this pull request Jun 17, 2025
* Update html.rb

added .razor files to html lexer

* Update html_spec.rb

added razor files to html spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants