Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Merging master branch #28

Merged
merged 19 commits into from
Dec 27, 2016
Merged

Conversation

adamantivm
Copy link
Contributor

Nothing much there besides a long parallel commit history and a few comment nits.

@stonier another pair of eyes just in case?

damonkohler and others added 18 commits October 21, 2013 14:04
Upgrades Gradle and Android build tools versions.
Reintroduce the license - master branch
Maven style open ranges and version bump.
Change plugin from ros-java to ros.
Conflicts:
	CHANGELOG.rst
	CMakeLists.txt
	cmake/rosjava.cmake.em
	env-hooks/15.rosjava.bash.em
	env-hooks/15.rosjava.sh.em
	package.xml
	src/rosjava_build_tools/create_android_project.py
	src/rosjava_build_tools/gradle/gradle/wrapper/gradle-wrapper.jar
	src/rosjava_build_tools/gradle/gradle/wrapper/gradle-wrapper.properties
	src/rosjava_build_tools/release.py
	src/rosjava_build_tools/templates/android_package/build.gradle.in
	src/rosjava_build_tools/templates/android_project/build.gradle.in
	src/rosjava_build_tools/templates/rosjava_msg_project/build.gradle.in
	src/rosjava_build_tools/templates/rosjava_package/CMakeLists.txt.in
	src/rosjava_build_tools/templates/rosjava_package/build.gradle.in
	src/rosjava_build_tools/templates/rosjava_project/build.gradle.in
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@adamantivm adamantivm requested a review from stonier December 26, 2016 09:55
@adamantivm
Copy link
Contributor Author

Note to the @googlebot : all these commits are already in the repository, this is only a merge from two different branches, so no new content besides that added by myself is included here.

@adamantivm
Copy link
Contributor Author

@stonier I left the sample target as it was and added more context to rosjava/rosjava_bootstrap#1 so that we can more thoroughly go and change things everywhere later.

@adamantivm adamantivm merged commit 84653b3 into rosjava:kinetic Dec 27, 2016
@adamantivm adamantivm deleted the obsolete/master branch December 27, 2016 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants