[humble] Add pause and resume service calls for rosbag2 recorder (Backport #1131) #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(recorder): Add pause and resume service calls. Add service calls to pause recording and resume recording. Fixes ros2#1130 Signed-off-by: Rick Shanor <[email protected]> * feat(recorder): pause, resume, and is_paused PR comments. Address PR comments. Add is_paused service. Update tests accordingly. Signed-off-by: Rick Shanor <[email protected]> Signed-off-by: Rick Shanor <[email protected]>
haudren-woven
requested review from
MichaelOrlov and
hidmic
and removed request for
a team
clalancette
reviewed
Aug 24, 2023
There was a problem hiding this comment.
The big problem in general with this backport is that it changes ABI by adding members to the Recorder class. Since our policy is to never break ABI in stable distributions, this is a problem.
One way to get around this is to to add in a global map of Recorder pointers to a structure containing the pieces you need. You can see an example of this pattern in ros2/rclcpp#2236 (look for the BackportMembers class).
MichaelOrlov
changed the title
MichaelOrlov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found a need to start & stop recording in my Humble installation. I figured that the services already exist in rosbag2_interfaces, so backporting is a very easy job. There were a couple of conflicts to manually resolve, which prevented me from going through Mergify.
Let me know if this is appropriate!