Skip to content

Commit

Permalink
Fix for possible freeze in Recorder::stop() (#1381)
Browse files Browse the repository at this point in the history
* Fix for possible freeze in Recorder::stop()

- It was possible a freeze in recorder due to the race condition when
calling Recorder::stop() while event publisher thread hasn't been fully
started yet.

Signed-off-by: Michael Orlov <[email protected]>

* Move event_publisher_thread_wake_cv_.notify_all() out of the mutex lock

Signed-off-by: Michael Orlov <[email protected]>

---------

Signed-off-by: Michael Orlov <[email protected]>
(cherry picked from commit c6cc69a)

# Conflicts:
#	rosbag2_transport/src/rosbag2_transport/recorder.cpp
  • Loading branch information
MichaelOrlov committed Jun 27, 2023
1 parent 07fd903 commit 32cc779
Showing 1 changed file with 546 additions and 0 deletions.
Loading

0 comments on commit 32cc779

Please sign in to comment.