Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 8.4.1. #147

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Changelog for 8.4.1. #147

merged 1 commit into from
Nov 25, 2024

Conversation

clalancette
Copy link
Contributor

Once this is approved, I will squash-merge it, tag the resulting commit on the rolling branch, and do a bloom-release of ros2_tracing.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette clalancette merged commit 0e64eb8 into rolling Nov 25, 2024
8 of 9 checks passed
@clalancette clalancette deleted the clalancette/8.4.1 branch November 25, 2024 16:38
@christophebedard
Copy link
Member

christophebedard commented Nov 25, 2024

Since changelog/release PRs are only made on a very small set of core repos, including this one and rosbag2, I'm wondering:

Is the goal of making this PR to get the changelog itself approved, or is it to check (I assume specifically with me) that creating a new release (and deciding whether to bump the minor number or the patch number) is OK, in case it might conflict with my plans? Or maybe a different reason?

@clalancette
Copy link
Contributor Author

Is the goal of making this PR to get the changelog itself approved, or is it to check (I assume specifically with me) that creating a new release (and deciding whether to bump the minor number or the patch number) is OK, in case it might conflict with my plans? Or maybe a different reason?

It is more the latter; to check with you that this is an OK release to make.

To be perfectly frank, now that we are under one umbrella under the OSRA, it might make sense to get rid of this distinction for ros2_tracing and rosbag2 and just push directly to rolling like we do for the other repositories. It definitely makes life easier when doing "mass" releases into Rolling.

I'll add an item for the ROS PMC meeting tomorrow.

@christophebedard
Copy link
Member

Agreed, I was asking because I don't think this special treatment is really necessary.

If someone (e.g., ROS boss) is planning to do anything weird or special, release- or changelog-wise, I'd expect them to ping the package's maintainer anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants