Ignore actionlib_msgs deprecation warnings #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Perron <[email protected]>
|
If the referenced PR is being updated with this comment (ament/ament_cmake#223 (comment)) only that specific deprecation message can be silenced. |
This time only ignore the single message we care to ignore Signed-off-by: Jacob Perron <[email protected]>
|
I've updated both PRs to allow for alternative approach, which quiets the single warning we care to ignore. |
dirk-thomas
approved these changes
Mar 11, 2020
chapulina
approved these changes
Mar 11, 2020
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ros2/build_farmer#267
Depends on ament/ament_cmake#223
Note, this change will ignore all deprecation warnings produced by calling
find_package(actionlib_msgs). I'm not sure of a nice way in CMake to ignore a single message coming from a command, but I think this solution is reasonable since I don't expect other deprecation warnings to come from findingactionlib_msgs. Alternatively, we could introduce a new variable inament_cmaketo toggle the deprecation warning, e.g.actionlib_msgs_IGNORE_DEPRECATED, but it doesn't seem very elegant.