use rcpputils::get_env_var, remove obsolete function and added namespace

Signed-off-by: Dirk Thomas <[email protected]>

rmw_implementation/src/functions.cpp

@@ -35,37 +35,12 @@
 #define STRINGIFY_(s) #s
 #define STRINGIFY(s) STRINGIFY_(s)
 
-namespace
-{
-
-// TODO(eric.cousineau): Use rcutils_get_env pending debugging usage on
-// Windows.
-std::string get_env_var(const char * env_var)
-{
-  char * value = nullptr;
-#ifndef _WIN32
-  value = getenv(env_var);
-#else
-  size_t value_size;
-  _dupenv_s(&value, &value_size, env_var);
-#endif
-  std::string value_str = "";
-  if (value) {
-    value_str = value;
-#ifdef _WIN32
-    free(value);
-#endif
-  }
-  // printf("get_env_var(%s) = %s\n", env_var, value_str.c_str());
-  return value_str;
-}
-
 Poco::SharedLibrary *
 get_library()
 {
   static Poco::SharedLibrary * lib = nullptr;
   if (!lib) {
-    std::string env_var = get_env_var("RMW_IMPLEMENTATION");
+    std::string env_var = rcpputils::get_env_var("RMW_IMPLEMENTATION");
     if (env_var.empty()) {
       env_var = STRINGIFY(DEFAULT_RMW_IMPLEMENTATION);
     }
@@ -115,8 +90,6 @@ get_symbol(const char * symbol_name)
   return lib->getSymbol(symbol_name);
 }
 
-}  // namespace
-
 #ifdef __cplusplus
 extern "C"
 {