Provide a dummy readcdr function if needed #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Boasson <[email protected]>
|
Clearly there is still a need for it (see eclipse-cyclonedds/cyclonedds#538) and it has now been confirmed independently, I'm merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RMW layer in dashing/eloquent depends on a still-evolving interface for custom reader history caches in Cyclone. eclipse-cyclonedds/cyclonedds#499 extends that interface, this PR ensures the sources in the RMW layer will be compatible with Cyclone also after merging that PR.
I believe future proofing by a change of this nature makes sense anyway, but a mishap in implementing #142 means dashing today still relies on cyclonedds' master branch (it is a good thing Cyclone DDS regressions are pretty rare!). Therefore, eclipse-cyclonedds/cyclonedds#499 can only go into Cyclone after either this PR, or ros2/ros2#907 or both have been merged.
Note that Eloquent and Foxy are "safe": Eloquent because it uses cyclonedds:releases/0.5.x and Foxy because #145 removed the reliance on this interface.