If a waitset can't be immediately cleaned up, skip it instead of waiting

ros2 · Mar 20, 2020 · 5f0023a · 5f0023a
1 parent d05fced
commit 5f0023a
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/rmw_cyclonedds_cpp/src/rmw_node.cpp b/rmw_cyclonedds_cpp/src/rmw_node.cpp
@@ -2221,8 +2221,10 @@ static void clean_waitset_caches()
      used ... */
   std::lock_guard<std::mutex> lock(gcdds.lock);
   for (auto && ws : gcdds.waitsets) {
-    std::lock_guard<std::mutex> lock2(ws->lock);
-    waitset_detach(ws);
+    std::unique_lock<std::mutex> lock2(ws->lock, std::try_to_lock);
+    if (lock2.owns_lock()) {
+      waitset_detach(ws);
+    }
   }
 }