Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 for API Docs Link on ROS Index #1080

Open
ottojo opened this issue Feb 7, 2023 · 4 comments
Open

404 for API Docs Link on ROS Index #1080

ottojo opened this issue Feb 7, 2023 · 4 comments
Labels

Comments

@ottojo
Copy link

ottojo commented Feb 7, 2023

The ros index page for rclpy contains a "API Docs" link http://docs.ros.org/en/humble/p/rclpy, but the docs are not found at that URL.

Using google, i could only find docs for foxy (https://docs.ros2.org/foxy/api/rclpy/index.html) and galactic (https://docs.ros2.org/galactic/api/rclpy/index.html)

The CI job for generating (humble) docs seems to run, but docs are nowhere to be found: https://build.ros2.org/view/Hdoc/job/Hdoc__rclpy__ubuntu_jammy_amd64/

@clalancette
Copy link
Contributor

You did a good job tracking down how all of that works. In short, you are correct that we aren't currently generating anything for rclpy properly.

In order to get there, we need to land ros-infrastructure/rosdoc2#28 (which still needs some work), as well as do some custom configuration in rclpy itself. I'll leave this open as the issue to track the addition of that configuration.

@Dario-Mantegazza
Copy link

Hi,
it is probably too early to ask since the pull request cited above was just merged yesterday, but, when can we expect that the doc (for humble at least) will be published?
Thanks

@clalancette
Copy link
Contributor

it is probably too early to ask since the pull request cited above was just merged yesterday, but, when can we expect that the doc (for humble at least) will be published?

While we did get the PR landed, there are still additional follow-up fixes that are needed to rosdoc2. And we did not get the custom configuration in rclpy landed. And then we need to backport it to humble. We are slowly getting there, but it is still going to be some time to get it all working end-to-end.

@ottojo
Copy link
Author

ottojo commented May 30, 2023

Since the iron release is now out and the api-docs are built and correctly linked in the index, i'm happy with that resolution so far! I won't close this yet since backporting to humble is mentioned above, but if that should be moved to another issue, feel free to close this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants