Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups #134

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Cleanups #134

merged 2 commits into from
Jul 8, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 8, 2024

Removed RCUTILS_ASSERT and RCUTILS_BREAK TODOs, there no consensus in the PR ros2/rcutils#112 which is already closed.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from clalancette July 8, 2024 15:30
@ahcorde ahcorde self-assigned this Jul 8, 2024
@ahcorde ahcorde requested a review from gbiggs as a code owner July 8, 2024 15:30
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from clalancette July 8, 2024 16:06
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@ahcorde
Copy link
Contributor Author

ahcorde commented Jul 8, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit ffef8e5 into rolling Jul 8, 2024
2 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/cleanups branch July 9, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants