[Humble] Let XML executables/nodes be "required" (like in ROS 1) (#751) #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Let XML nodes be "required" Essentially on_exit="shutdown" is equivalent to ROS 1 required="true". This feature is implemented using the python launchfile on_exit mechanism. Right now "shutdown" is the only action accepted by on_exit, but theoretically more "on_exit" actions could be added later. Example: <executable cmd="ls" on_exit="shutdown"/> * Added tests for yaml Signed-off-by: Matthew Elwin <[email protected]>
|
Not sure why the DCO check is failing, I just cherry-picked the commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of the commit discussed here: #179
Supports "on_exit" for XML launch files in ROS 2 humble.
I tested it locally and it works as expected:
Essentially on_exit="shutdown" is equivalent to ROS 1 required="true".
This feature is implemented using the python launchfile on_exit mechanism.
Right now "shutdown" is the only action accepted by on_exit, but theoretically more "on_exit" actions could be added later.
Example: