Adds ARROW_STRIP to Marker.msg #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Noble <[email protected]>
ahcorde
approved these changes
Apr 10, 2024
|
delete-merged-branch
bot
deleted the
rivelinrobotics-feature/add-arrow-strip-marker-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #218 for a clean merge from @rr-tom-noble but since it's been queued so long it's out of date.
There's a partial implementation in ros2/rviz#972
However I would suggest that we land this in rolling to both keep it in sync with the ROS 1 version that's already added this. And to enable the use of the message with other implementations in the future. If we don't add this now it won't be able to be added for another year.