Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up license to be standard bsd 3 clause #130

Merged
merged 2 commits into from
Oct 29, 2020
Merged

clean up license to be standard bsd 3 clause #130

merged 2 commits into from
Oct 29, 2020

Conversation

tfoote
Copy link
Member

@tfoote tfoote commented Jan 31, 2020

This was propagated due to an invalid license in ament_lint which is proposed to be fixed at: ament/ament_lint#209

@tfoote tfoote requested a review from clalancette February 8, 2020 02:27
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @tfoote I'll leave it to you to merge once ament/ament_lint#209 is merged.

@clalancette
Copy link
Contributor

Actually, I misunderstood the situation. I'm going to run CI on this just to double check that CI is happy, then I'll go ahead and merge.

@clalancette
Copy link
Contributor

clalancette commented Oct 23, 2020

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

I've rebased this one onto the latest, and also updated the formatting so that it passes the linters. I think this is now ready to go, but @tfoote I'd appreciate a review from you to check my work. Once I have that, I'll go ahead and merge this.

@clalancette
Copy link
Contributor

I'm going to go ahead and merge this one. It doesn't change any licenses, it just updates the formatting so that it passes our linters.

@clalancette clalancette merged commit 2a2c8d2 into ros2 Oct 29, 2020
@clalancette clalancette deleted the bsd3clause branch October 29, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants