Skipping flaky tests #413
Merged
Skipping flaky tests #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Henkel <[email protected]>
Signed-off-by: Christian Henkel <[email protected]>
Signed-off-by: Christian Henkel <[email protected]>
Signed-off-by: Christian Henkel <[email protected]>
ct2034
added a commit
to ct2034/diagnostics
that referenced
this pull request
Dec 6, 2024
* skipping flaky ntp test Signed-off-by: Christian Henkel <[email protected]> * Also skipping tests in diagnostic_aggregator Signed-off-by: Christian Henkel <[email protected]> * also the test_critical_pub skipped Signed-off-by: Christian Henkel <[email protected]> * oh no .. Signed-off-by: Christian Henkel <[email protected]> --------- Signed-off-by: Christian Henkel <[email protected]> (cherry picked from commit beb9935) # Conflicts: # diagnostic_updater/CMakeLists.txt
ct2034
added a commit
to ct2034/diagnostics
that referenced
this pull request
Dec 6, 2024
* skipping flaky ntp test Signed-off-by: Christian Henkel <[email protected]> * Also skipping tests in diagnostic_aggregator Signed-off-by: Christian Henkel <[email protected]> * also the test_critical_pub skipped Signed-off-by: Christian Henkel <[email protected]> * oh no .. Signed-off-by: Christian Henkel <[email protected]> --------- Signed-off-by: Christian Henkel <[email protected]> (cherry picked from commit beb9935) # Conflicts: # diagnostic_updater/CMakeLists.txt
ct2034
added a commit
to ct2034/diagnostics
that referenced
this pull request
Dec 6, 2024
* skipping flaky ntp test Signed-off-by: Christian Henkel <[email protected]> * Also skipping tests in diagnostic_aggregator Signed-off-by: Christian Henkel <[email protected]> * also the test_critical_pub skipped Signed-off-by: Christian Henkel <[email protected]> * oh no .. Signed-off-by: Christian Henkel <[email protected]> --------- Signed-off-by: Christian Henkel <[email protected]> (cherry picked from commit beb9935)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
ct2034
added a commit
that referenced
this pull request
Dec 6, 2024
* skipping flaky ntp test Signed-off-by: Christian Henkel <[email protected]> * Also skipping tests in diagnostic_aggregator Signed-off-by: Christian Henkel <[email protected]> * also the test_critical_pub skipped Signed-off-by: Christian Henkel <[email protected]> * oh no .. Signed-off-by: Christian Henkel <[email protected]> --------- Signed-off-by: Christian Henkel <[email protected]> (cherry picked from commit beb9935)
ct2034
added a commit
that referenced
this pull request
Dec 6, 2024
* skipping flaky ntp test Signed-off-by: Christian Henkel <[email protected]> * Also skipping tests in diagnostic_aggregator Signed-off-by: Christian Henkel <[email protected]> * also the test_critical_pub skipped Signed-off-by: Christian Henkel <[email protected]> * oh no .. Signed-off-by: Christian Henkel <[email protected]> --------- Signed-off-by: Christian Henkel <[email protected]> (cherry picked from commit beb9935) # Conflicts: # diagnostic_updater/CMakeLists.txt
ct2034
added a commit
that referenced
this pull request
Dec 6, 2024
* skipping flaky ntp test Signed-off-by: Christian Henkel <[email protected]> * Also skipping tests in diagnostic_aggregator Signed-off-by: Christian Henkel <[email protected]> * also the test_critical_pub skipped Signed-off-by: Christian Henkel <[email protected]> * oh no .. Signed-off-by: Christian Henkel <[email protected]> --------- Signed-off-by: Christian Henkel <[email protected]> (cherry picked from commit beb9935) # Conflicts: # diagnostic_updater/CMakeLists.txt
MrBlenny
added a commit
to Greenroom-Robotics/diagnostics
that referenced
this pull request
Dec 12, 2024
* Add missing rclpy dependency to common_diagnostics to fix rosdoc2 output (ros#402) * Skipping flaky ntp test (ros#409) * skipping flaky ntp test Signed-off-by: Christian Henkel <[email protected]> * Also skipping tests in diagnostic_aggregator Signed-off-by: Christian Henkel <[email protected]> --------- Signed-off-by: Christian Henkel <[email protected]> * Skipping flaky tests (ros#413) * skipping flaky ntp test Signed-off-by: Christian Henkel <[email protected]> * Also skipping tests in diagnostic_aggregator Signed-off-by: Christian Henkel <[email protected]> * also the test_critical_pub skipped Signed-off-by: Christian Henkel <[email protected]> * oh no .. Signed-off-by: Christian Henkel <[email protected]> --------- Signed-off-by: Christian Henkel <[email protected]> * feat: add publish_values parameter --------- Signed-off-by: Christian Henkel <[email protected]> Co-authored-by: R Kent James <[email protected]> Co-authored-by: Christian Henkel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.