common_diagnostics cleaned hostname string #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just curious, for compatibility with what? There are no active ROS distributions on python versions older than 3.8 |
|
Oh, that's true. Somehow I was thinking about the 3.6 requirements of ROS 2. |
ct2034
approved these changes
Dec 3, 2024
Signed-off-by: Christian Henkel <[email protected]>
ct2034
pushed a commit
to ct2034/diagnostics
that referenced
this pull request
Dec 18, 2024
* Hostnames are properly cleaned to only contain alphanumeric characters or underscore. * changed string sanitation (symbols must be ascii and alphanumeric) * Changes now conforming to linting rules * flake8 fixes Signed-off-by: Christian Henkel <[email protected]> --------- Signed-off-by: Christian Henkel <[email protected]> Co-authored-by: Christian Henkel <[email protected]> (cherry picked from commit cca0f14)
ct2034
pushed a commit
to ct2034/diagnostics
that referenced
this pull request
Dec 18, 2024
* Hostnames are properly cleaned to only contain alphanumeric characters or underscore. * changed string sanitation (symbols must be ascii and alphanumeric) * Changes now conforming to linting rules * flake8 fixes Signed-off-by: Christian Henkel <[email protected]> --------- Signed-off-by: Christian Henkel <[email protected]> Co-authored-by: Christian Henkel <[email protected]> (cherry picked from commit cca0f14)
ct2034
pushed a commit
to ct2034/diagnostics
that referenced
this pull request
Dec 18, 2024
* Hostnames are properly cleaned to only contain alphanumeric characters or underscore. * changed string sanitation (symbols must be ascii and alphanumeric) * Changes now conforming to linting rules * flake8 fixes Signed-off-by: Christian Henkel <[email protected]> --------- Signed-off-by: Christian Henkel <[email protected]> Co-authored-by: Christian Henkel <[email protected]> (cherry picked from commit cca0f14)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
ct2034
added a commit
that referenced
this pull request
Dec 18, 2024
* Hostnames are properly cleaned to only contain alphanumeric characters or underscore. * changed string sanitation (symbols must be ascii and alphanumeric) * Changes now conforming to linting rules * flake8 fixes Signed-off-by: Christian Henkel <[email protected]> --------- Signed-off-by: Christian Henkel <[email protected]> Co-authored-by: Christian Henkel <[email protected]> (cherry picked from commit cca0f14) Co-authored-by: sjusner <[email protected]>
ct2034
added a commit
that referenced
this pull request
Dec 18, 2024
* Hostnames are properly cleaned to only contain alphanumeric characters or underscore. * changed string sanitation (symbols must be ascii and alphanumeric) * Changes now conforming to linting rules * flake8 fixes Signed-off-by: Christian Henkel <[email protected]> --------- Signed-off-by: Christian Henkel <[email protected]> Co-authored-by: Christian Henkel <[email protected]> (cherry picked from commit cca0f14) Co-authored-by: sjusner <[email protected]>
ct2034
added a commit
that referenced
this pull request
Dec 18, 2024
* Hostnames are properly cleaned to only contain alphanumeric characters or underscore. * changed string sanitation (symbols must be ascii and alphanumeric) * Changes now conforming to linting rules * flake8 fixes Signed-off-by: Christian Henkel <[email protected]> --------- Signed-off-by: Christian Henkel <[email protected]> Co-authored-by: Christian Henkel <[email protected]> (cherry picked from commit cca0f14) Co-authored-by: sjusner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #404. hostname used for node name now only contains alphanumeric and underscore.
Did not introduced any new libraries, also avoided python 3.7 specific feature for compatibility.