Cleanup bsd 3 clause license usage #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tully Foote <[email protected]>
dgossow
approved these changes
Feb 1, 2020
jacobperron
previously approved these changes
Feb 4, 2020
jacobperron
reviewed
Feb 4, 2020
|
|
||
| // * Redistributions of source code must retain the above copyright | ||
| // notice, this list of conditions and the following disclaimer. | ||
|
|
There was a problem hiding this comment.
The blank lines look wrong
|
@tfoote did you not see @jacobperron's comment? Also, this package is part of ROS 2 CI, you shouldn't merge a change without running CI... |
|
Sorry, I didn't realize that this was in the repos file now. And Jacob had dismissed his review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was propagated due to an invalid license in ament_lint which is proposed to be fixed at: ament/ament_lint#209