-
Notifications
You must be signed in to change notification settings - Fork 60
Conversation
bacc03f
to
08e72e3
Compare
Co-authored-by: Emerson Knapp <[email protected]> Signed-off-by: TSC21 <[email protected]>
08e72e3
to
d2207a6
Compare
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 11 11
Lines 414 414
=======================================
Hits 386 386
Misses 28 28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
5919344
to
2b8adea
Compare
…/osrf/multiarch-docker-image-generation In order to work around https://bugs.launchpad.net/qemu/+bug/1805913 and so qemu supports renameat2() syscall. Signed-off-by: TSC21 <[email protected]>
2b8adea
to
8aa54a2
Compare
For some reason, it fails to fetch the GPG keys for Noetic in Debian Buster in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I don't feel too awesome about copying the qemu binaries into this repo. But I think it gets the job done so I'm not going to complain too loudly.
An alternative approach might be to download from the place where they are stored for the multiarch image generation.
* add support for ROS Noetic * Use the same qemu binaries as the ones provided in https://github.com/osrf/multiarch-docker-image-generation In order to work around https://bugs.launchpad.net/qemu/+bug/1805913 and so qemu supports renameat2() syscall. Signed-off-by: TSC21 <[email protected]> Co-authored-by: Emerson Knapp <[email protected]>
Continues #290.