Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run apt update if skipRosdepInstall==true #942

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not run apt update if skipRosdepInstall==true #942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a67fd28
Do not run `apt update` if `skipRosdepInstall==true`
roncapat Dec 9, 2024
e417233
Implement review comments
roncapat Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31173,7 +31173,7 @@ done`;
yield execShellCommand(["vcs import --force --recursive src/ < package.repo"], options);
// Print HEAD commits of all repos
yield execShellCommand(["vcs log -l1 src/"], options);
if (isLinux) {
if (isLinux && !skipRosdepInstall) {
// Always update package index before installing packages
const dist = yield determineDistrib();
roncapat marked this conversation as resolved.
Show resolved Hide resolved
if (dist === "ubuntu") {
Expand Down
2 changes: 1 addition & 1 deletion src/action-ros-ci.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ done`;
// Print HEAD commits of all repos
await execShellCommand(["vcs log -l1 src/"], options);

if (isLinux) {
if (isLinux && !skipRosdepInstall) {
// Always update package index before installing packages
const dist: string = await determineDistrib();
if (dist === "ubuntu") {
Expand Down
Loading