Set twist_mux/use_stamped to default false, to match twist_marker #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I noticed when updating the workspace I've been using for my hobby projects. The
use_stamped
parameter intwist_marker
is defaulting tofalse
, but the same parameter intwist_mux
must be explicitly set or the node will throw an exception and die.I'm making an assumption that when
use_stamped
was added to thetwist_mux
node, it was intentionally added without a default value to force developers to evaluate their usage of the node. I actually agree with that direction, if that was the intention, but at the same time it's pretty annoying that the two nodes in this package have different behaviours where one is optional and the other is not.This PR changes
/twist_mux/use_stamped
to default tofalse
when the node is created, and declares it as a parameter fortwist_mux
instead of just blindly looking in the global namespace.There is also the matter that Steve M brought up regarding the default value of this parameter with Nav2. . I don't address that issue here, it's orthoganal to the merits of having a parameter act uniformly across the package.