Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversions for YUY2 (YUYV) encoding #309

Closed
wants to merge 2 commits into from

Conversation

sgvandijk
Copy link

In ros2/common_interfaces#78 the yuv422_yuy2 image encoding was added, which is the format commonly coming out of webcams.

This PR adds conversions from this format, in line with the existing yuv422 ones for UYVY.

@mjcarroll
Copy link
Contributor

@ros-pull-request-builder retest this please

@mjcarroll mjcarroll added the ros2 label Jan 4, 2020
@sgvandijk
Copy link
Author

I guess this is blocked until common_interfaces makes a new release, which seems to be 1.0 as tracked in ros2/common_interfaces#84

@threeal
Copy link

threeal commented May 19, 2020

it has been a long time, when will it going to be released?

@HorvathDawson
Copy link

Should we expect this to be released soon?

@sgvandijk sgvandijk force-pushed the yuv422-yuy2 branch 2 times, most recently from 712e614 to 36adbcc Compare June 8, 2020 22:05
@sgvandijk
Copy link
Author

The sensor_msgs packages which defines the required image format has now been released and is available for Focal. I've rebased to test with the latest versions and it looks like it now compiles fine with Foxy/Focal, not with Dashing/Bionic as expected. @mjcarroll should I try to make it backward compatible (not sure how) or is this fine?

@russkel
Copy link

russkel commented Jun 19, 2020

Thanks for work on this @sgvandijk. Useful since the raspberry pi camera modules only seem to be ROS1.

Signed-off-by: Sander G. van Dijk <[email protected]>
Signed-off-by: Sander G. van Dijk <[email protected]>
@sgvandijk
Copy link
Author

sgvandijk commented Aug 7, 2020

@mjcarroll I've rebased to latest ros2 again. It'd be great if this can get in so we can finally release the integration of cv_bridge in the V4L2 camera driver.

@russkel
Copy link

russkel commented Aug 9, 2020

You might want to take out bionic of the CI testing in this branch?

@pmusau17 pmusau17 mentioned this pull request Jul 9, 2021
@mjcarroll
Copy link
Contributor

Superceded by #396

@mjcarroll mjcarroll closed this Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants