Pr support user doc dir

[rkent]

Under current rosdoc2, several concepts are conflated:

1. My user documentation is in a non-standard folder (that is, not in doc/ or doc/source).
2. I want rosdoc2 to use a custom conf.py rather than the default.
3. I want rosdoc2 to only show the documentation that I specify, not its other items (like Links, Standard Documents, etc) that have been added in the last few months.

These three concepts were enabled by whether you included a conf.py (either in standard location, or specified by sphinx_sourcedir). There was no way to specify, for example, that my documentation is in docs/ rather than doc/, but I do not include conf.py, and I do not want to override the standard rosdoc2 output.

With this change, you specify the three choices as follows (using the three options above):

1. specify a (new) rosdoc2 option 'user_doc_dir' in rosdoc2.yaml, showing where the user documents are located.
2. include a conf.py in the location specified for user documentation (either a standard location, or one specified by user_doc_directory or sphinx_sourcedir).
3. define sphinx_sourcedir in rosdoc2.yaml.

This is a behavior change that will affect a few existing packages: those that specified conf.py in a standard doc location (either doc/ or doc/source), but did not specify sphinx_sourcedir. Previously, it was assumed that this was equivalent to specifying sphinx_sourcedir, but that is no longer the case. This PR has two effects on those packages. First, the documentation that previously was the entire rosdoc2 output is now a link under "Documentation", and the root of the rosdoc2 output shows the standard rosdoc2 items, like "Links", "Standard Documents", etc. Second, previously the root of the project was the implied sphinx_sourcedir (either doc/ or doc/source), now the root of the project is the package.xml directory. In many cases this has no effect, but if the supplied documentation has links to generated content, that now needs to be at "../generated" not "generated" so those links fail (but the generated content still shows by default in the standard rosdoc2 links).

I have prepared a full run of rosdoc2 on rolling with this PR applied, that is available at https://prrosdoc2.rosdabbler.com/ I also scanned rolling packages, looking for those that define conf.py. I include a full list later, but here are a few examples;

Packages that previously showed only documentation, now show full rosdoc2 output plus documentation: message_filters, rviz2, image_proc

Packages that have broken API links in their custom documentation: realtime_tools, control_toolbox

A few packages had odd behavior which I investigated and decided were unrelated to this PR:

launch: works in https://docs.ros.org/en/ros2_packages/rolling/api/launch/ but broken at https://prrosdoc2.rosdabbler.com/ This is because the build farm is using Sphinx 7.4.7, with launch showing: "WARNING: The pre-Sphinx 1.0 'intersphinx_mapping' format is deprecated and will be removed in Sphinx 8" rosdabbler uses Sphinx 8, and this is now broken.

cv_bridge: is broken in both (but is fixed in PRs to come, see https://rosdoc2.rosdabbler.com/cv_bridge/)

ur_client_library: shows from June 2024 at https://docs.ros.org/en/ros2_packages/rolling/api/ur_client_library/ but is broken in rosdabbler. I believe this is from a change in the repo, and the current repo would also break in current rosdoc2.

I did not check all of the packages that might be affected, but you are free to do your own checks.

There is a related change in this PR as well. Because essentially package content is copied to the build directory in rosdoc2, there is no need to rename directories as was done previously. I am reverting to using the existing directory names (like 'doc') rather than an artificial name (like 'user_docs'). By preserving the existing doc structure, relative links in user documentation are more likely to work. I am not aware of any current packages that this affects.

In the future, many packages can specify user_doc_dir and have documentation shown that is currently missing. At https://rosdoc2.rosdabbler.com I have included (from future PRs) a curated "correction" file for package rosdoc2.yaml that exposes some of this. See for example rmw_dds_common, tracetools_analysis or rosidl_runtime_c which need user_doc_dir to show their existing documentation.

There are other existing packages that specify sphinx_sourcedir, but would be better off just specifying user_doc_dir. I have not seached for those here.

Affected packages:

found doc/source/conf.py in mrpt_path_planning at ./mrpt_path_planning
found doc/conf.py in geodesy at ./geographic_info/geodesy
found doc/conf.py in realtime_tools at ./realtime_tools
found doc/conf.py in message_filters at ./message_filters
found doc/source/conf.py in launch at ./launch/launch
found doc/conf.py in fuse_doc at ./fuse/fuse_doc
found doc/conf.py in quaternion_operation at ./quaternion_operation
found doc/conf.py in robot_localization at ./robot_localization
found doc/conf.py in ffmpeg_image_transport at ./ffmpeg_image_transport
found doc/conf.py in rviz2 at ./rviz/rviz2
found doc/conf.py in control_msgs at ./control_msgs/control_msgs
found doc/source/conf.py in tf2_ros_py at ./geometry2/tf2_ros_py
---tf2_ros_py defines sphinx_sourcedir
found doc/conf.py in tf2_ros at ./geometry2/tf2_ros
found doc/conf.py in ros2_controllers at ./ros2_controllers/ros2_controllers
found doc/conf.py in ur_client_library at ./ur_client_library
found doc/conf.py in ffmpeg_image_transport_tools at ./ffmpeg_image_transport_tools
found doc/conf.py in rviz_2d_overlay_plugins at ./rviz_2d_overlay_plugins/rviz_2d_overlay_plugins
found doc/conf.py in spinnaker_synchronized_camera_driver at ./flir_camera_driver/spinnaker_synchronized_camera_driver
found doc/conf.py in spinnaker_camera_driver at ./flir_camera_driver/spinnaker_camera_driver
found doc/conf.py in foxglove_compressed_video_transport at ./foxglove_compressed_video_transport
found doc/conf.py in event_camera_py at ./event_camera_py
found doc/conf.py in control_toolbox at ./control_toolbox
found doc/conf.py in camera_calibration at ./image_pipeline/camera_calibration
found doc/conf.py in depth_image_proc at ./image_pipeline/depth_image_proc
found doc/conf.py in image_proc at ./image_pipeline/image_proc
found doc/conf.py in image_publisher at ./image_pipeline/image_publisher
found doc/conf.py in image_view at ./image_pipeline/image_view
found doc/conf.py in image_pipeline at ./image_pipeline/image_pipeline
---image_pipeline defines sphinx_sourcedir
found doc/conf.py in image_rotate at ./image_pipeline/image_rotate
found doc/conf.py in stereo_image_proc at ./image_pipeline/stereo_image_proc
found doc/conf.py in ur_calibration at ./ur_robot_driver/ur_calibration
found doc/conf.py in ur_robot_driver at ./ur_robot_driver/ur_robot_driver
found doc/conf.py in cv_bridge at ./vision_opencv/cv_bridge
found doc/conf.py in image_geometry at ./vision_opencv/image_geometry
found doc/conf.py in point_cloud_transport at ./point_cloud_transport/point_cloud_transport
---point_cloud_transport defines sphinx_sourcedir
found doc/conf.py in transmission_interface at ./ros2_control/transmission_interface
found doc/conf.py in ros2_control at ./ros2_control/ros2_control
---ros2_control defines sphinx_sourcedir

[tfoote]

Overall this looks good. message_filters looks a lot more complete.

I think unrelated I saw that at https://prrosdoc2.rosdabbler.com/rclcpp/generated/classrclcpp_1_1Node.html#classrclcpp_1_1Node

There's a lot of extra class references, whereas at
https://docs.ros.org/en/rolling/p/rclcpp/generated/classrclcpp_1_1Node.html#classrclcpp_1_1Node it looks to be only local references. Is this because you're using the scan approach?

And when I tried to click on it the URLs were wrong for the class references. Aka BatteryStateDisplay links to a bad url http://docs.ros.org/en/latest/p/battery_state_rviz_overlay/generated/classBatteryStateDisplay.html#classBatteryStateDisplay It looks like that might be getting a wrong site prefix.

https://prrosdoc2.rosdabbler.com/battery_state_rviz_overlay/generated/classBatteryStateDisplay.html#classBatteryStateDisplay seemed to resolve with that. And it's also referencing latest instead of rolling

[tfoote]

Did you intentionally change this to be a relative directory instead of an absolute one?

[tfoote]

Nevermind I see it's joined below

[rkent]

Concerning "I think unrelated I saw that at ... ":

Two things are going on here, both more related to my Jenkins instance than to rosdoc2 changes.

First, yes because I am using a scan of the entire distro (unlike buildfarm which I think is using a buildfarm equivalent of the scan, but only for a single repo), I get full cross-references, and not just the repo cross references. Also even though I make no attempt to run the individual rosdoc2 instances in a dependency order, because the cross reference files are preserved between runs, the previous run will almost always show a correct cross-reference link even if the runs are not dependency order. Node just happens to have a lot of cross-reference links. Actually that list is useful, it shows you all of the packages currently defining C++ nodes.

Second, I am running rosdoc2 simply as "scan -p /checkout -t 3600" so I am not setting the base_url but instead using the default. The default is "http://docs.ros.org/en/latest/p" which goes nowhere. Maybe there used to be a link to 'latest' but there no longer appears to be. We should fix that either on the buildfarm, or use perhaps 'rolling' here instead as the default.

I'll fix my buildfarm to point to the correct URL and rerun so we can see the dependency links.