Spike out a change to allow overriding the source package requirement. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Considering the possibility of using this repository for gurumdds updates as well but since that's a proprietary package redistributed by agreement it does not have source packages available and thus we would need to be able to override our own check. This is a minimal change which adds a new implicitly boolean field but I'd like to get feedback on further refactoring to allow overrides to be package specific (although I have no immediate use case for it). Examples: Override all source requirements: ``` override_sources_required: true ``` Override requirements for specific packages ``` override_sources_required: - gurumdds-2.6 - gurumdds-2.7 ```
tfoote
reviewed
Jul 8, 2021
| self.__error(f'{self.__get_mirror_name(dist)} does not have a source package. Removing generated mirrors') | ||
| self.__log_ok('All source packages exist in the mirror') | ||
| # 2. Be sure mirror has all source packages unless the requirement is overridden. | ||
| if not self.config.override_sources_required: |
There was a problem hiding this comment.
It always logs that it's verifying the sources. For this case it would be good to log that it's explicitly skipping the check based on the config.
|
depending on urgency, it would be great to add a test for this case. Otherwise, looks good to me. |
|
I agree adding a test is a requirement for getting this in and I like Tully's suggestion of logging the override. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering the possibility of using this repository for gurumdds
updates as well but since that's a proprietary package redistributed by
agreement it does not have source packages available and thus we would
need to be able to override our own check.
This is a minimal change which adds a new implicitly boolean field but
I'd like to get feedback on further refactoring to allow overrides to be
package specific (although I have no immediate use case for it).
Examples:
Override all source requirements:
Override requirements for specific packages