Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package to compile in Jazzy #539

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Add package to compile in Jazzy #539

merged 4 commits into from
Oct 30, 2024

Conversation

thomasemter
Copy link
Contributor

No description provided.

@Ar-Ray-code
Copy link

I found a build error in Jazzy and it worked fine with your corrected code. Thanks 🙏.

@thomasemter
Copy link
Contributor Author

Great! Thank you for the feedback @Ar-Ray-code.

clalancette
clalancette approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change. I ended up simplifying this so that we are only adding in the test dependency here. With that, I'm going to approve and merge this.

@clalancette clalancette merged commit f802360 into ros-drivers:ros2 Oct 30, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasemter @Ar-Ray-code @clalancette