Override device_id when device_name is provided. (#199) #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of issue and solution: #199.
Testing:
I ran a bunch of manual tests for this with 1 controller plugged in. The controller is connected to
/dev/input/js0
and its name is 'Core (Plus) Wired Controller'. For each of these test blocks you can see the command I used and also the stdout. See comments above each block for more details.Setup:
ROS Foxy, Pop!_OS 20.04, wired PowerA Nintendo Switch controller plugged in as /dev/input/js0